-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract auto-update logic from aries #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee
changed the title
Extract auto-update logic from aries
WIP: Extract auto-update logic from aries
Oct 19, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 51.33% 51.34% +0.01%
==========================================
Files 150 150
Lines 22787 22820 +33
Branches 6023 6025 +2
==========================================
+ Hits 11697 11718 +21
- Misses 7481 7495 +14
+ Partials 3609 3607 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Looks promising! 🚀 |
mirgee
force-pushed
the
refactor/extract-update-state
branch
from
October 20, 2020 10:28
bc37b75
to
6c7c4d6
Compare
mirgee
changed the title
WIP: Extract auto-update logic from aries
Extract auto-update logic from aries
Oct 20, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee
force-pushed
the
refactor/extract-update-state
branch
from
October 20, 2020 18:48
6c7c4d6
to
29c5c0e
Compare
Patrik-Stas
approved these changes
Oct 21, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # libvcx/src/aries/handlers/issuance/holder/holder.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #128
Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com