Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract auto-update logic from aries #155

Merged
merged 7 commits into from
Oct 22, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 19, 2020

Addressing issue #128

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee requested a review from a team as a code owner October 19, 2020 13:51
@mirgee mirgee changed the title Extract auto-update logic from aries WIP: Extract auto-update logic from aries Oct 19, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #155 into master will increase coverage by 0.01%.
The diff coverage is 44.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   51.33%   51.34%   +0.01%     
==========================================
  Files         150      150              
  Lines       22787    22820      +33     
  Branches     6023     6025       +2     
==========================================
+ Hits        11697    11718      +21     
- Misses       7481     7495      +14     
+ Partials     3609     3607       -2     
Flag Coverage Δ
#unittests 51.34% <44.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/credential.rs 37.44% <0.00%> (ø)
libvcx/src/api/disclosed_proof.rs 42.37% <0.00%> (ø)
...aries/handlers/connection/inviter/state_machine.rs 69.19% <ø> (+1.60%) ⬆️
libvcx/src/connection.rs 64.46% <0.00%> (-3.45%) ⬇️
libvcx/src/messages/get_message.rs 35.18% <0.00%> (-1.53%) ⬇️
libvcx/src/aries/handlers/connection/connection.rs 50.19% <14.28%> (+2.17%) ⬆️
libvcx/src/credential.rs 54.46% <23.52%> (-3.00%) ⬇️
libvcx/src/disclosed_proof.rs 67.06% <26.66%> (-2.52%) ⬇️
libvcx/src/proof.rs 78.35% <42.30%> (-4.91%) ⬇️
libvcx/src/issuer_credential.rs 57.69% <52.38%> (-1.86%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb0f34...273cdef. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas
Copy link
Contributor

Looks promising! 🚀

@mirgee mirgee force-pushed the refactor/extract-update-state branch from bc37b75 to 6c7c4d6 Compare October 20, 2020 10:28
@mirgee mirgee changed the title WIP: Extract auto-update logic from aries Extract auto-update logic from aries Oct 20, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the refactor/extract-update-state branch from 6c7c4d6 to 29c5c0e Compare October 20, 2020 18:48
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

# Conflicts:
#	libvcx/src/aries/handlers/issuance/holder/holder.rs
@Patrik-Stas Patrik-Stas merged commit e2413d7 into master Oct 22, 2020
@Patrik-Stas Patrik-Stas deleted the refactor/extract-update-state branch October 22, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants