Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revocation registry rotation scenarios #136

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 13, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

@mirgee mirgee force-pushed the tests/cred-scenarios branch 3 times, most recently from 41c691f to 0b0c042 Compare October 13, 2020 13:59
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the tests/cred-scenarios branch from 0b0c042 to cc7e77a Compare October 13, 2020 15:11
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the tests/cred-scenarios branch from 8f39950 to 737779d Compare October 14, 2020 12:36
@mirgee mirgee changed the title WIP: Revocation registry rotation scenarios Revocation registry rotation scenarios Oct 14, 2020
@mirgee mirgee requested a review from Patrik-Stas October 14, 2020 13:11
@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #136 into master will decrease coverage by 0.00%.
The diff coverage is 60.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   50.82%   50.81%   -0.01%     
==========================================
  Files         152      152              
  Lines       22826    22852      +26     
  Branches     6043     6046       +3     
==========================================
+ Hits        11601    11612      +11     
- Misses       7645     7658      +13     
- Partials     3580     3582       +2     
Flag Coverage Δ
#unittests 50.81% <60.96%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/aries/handlers/issuance/messages.rs 30.76% <0.00%> (ø)
libvcx/src/aries/mod.rs 8.67% <0.00%> (ø)
libvcx/src/disclosed_proof.rs 66.11% <0.00%> (-1.40%) ⬇️
libvcx/src/filters.rs 40.35% <0.00%> (-17.15%) ⬇️
libvcx/src/issuer_credential.rs 59.54% <22.22%> (ø)
libvcx/src/lib.rs 33.64% <64.13%> (+0.24%) ⬆️
...aries/handlers/proof_presentation/prover/prover.rs 49.54% <75.00%> (+1.42%) ⬆️
...rc/aries/handlers/issuance/issuer/state_machine.rs 65.03% <93.75%> (-0.16%) ⬇️
libvcx/src/api/issuer_credential.rs 38.57% <100.00%> (ø)
...ibvcx/src/aries/handlers/issuance/issuer/issuer.rs 69.04% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2820502...1ebf5c8. Read the comment docs.

@mirgee mirgee force-pushed the tests/cred-scenarios branch from 916945a to f2b0db9 Compare October 15, 2020 06:46
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the tests/cred-scenarios branch from f2b0db9 to 481b7f7 Compare October 15, 2020 11:10
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit 5753e0a into master Oct 15, 2020
@Patrik-Stas Patrik-Stas deleted the tests/cred-scenarios branch October 15, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants