Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete legacy decryption code, authenticate connection msgs #134

Merged
merged 11 commits into from
Oct 20, 2020
Merged

Delete legacy decryption code, authenticate connection msgs #134

merged 11 commits into from
Oct 20, 2020

Conversation

Patrik-Stas
Copy link
Contributor

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-io
Copy link

codecov-io commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #134 into master will increase coverage by 0.65%.
The diff coverage is 51.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   50.76%   51.42%   +0.65%     
==========================================
  Files         151      150       -1     
  Lines       22798    22669     -129     
  Branches     6028     5987      -41     
==========================================
+ Hits        11574    11658      +84     
+ Misses       7654     7419     -235     
- Partials     3570     3592      +22
Flag Coverage Δ
#unittests 51.42% <51.20%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/proof.rs 52.86% <0.00%> (-0.28%) ⬇️
libvcx/src/api/wallet.rs 49.52% <ø> (ø)
...aries/handlers/connection/inviter/state_machine.rs 67.59% <0.00%> (-0.64%) ⬇️
libvcx/src/aries/handlers/connection/mod.rs 68.57% <ø> (ø)
...essages/proof_presentation/presentation_request.rs 62.63% <0.00%> (ø)
libvcx/src/aries/mod.rs 8.12% <0.00%> (-0.56%) ⬇️
libvcx/src/messages/mod.rs 37.12% <0.00%> (-1.52%) ⬇️
libvcx/src/messages/payload.rs 0.00% <0.00%> (ø)
libvcx/src/messages/update_message.rs 26.58% <ø> (ø)
libvcx/src/utils/libindy/payments.rs 42.98% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fd9aa...abcf125. Read the comment docs.

@Patrik-Stas Patrik-Stas force-pushed the cleanup/legacy-decryption branch 4 times, most recently from 1736eee to 519502f Compare October 14, 2020 14:43
@Patrik-Stas Patrik-Stas changed the title Delete legacy decryption code Delete legacy decryption code, authenticate connection messages possible Oct 15, 2020
@Patrik-Stas Patrik-Stas changed the title Delete legacy decryption code, authenticate connection messages possible Delete legacy decryption code, authenticate connection msgs Oct 15, 2020
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner October 16, 2020 07:51
@Patrik-Stas Patrik-Stas force-pushed the cleanup/legacy-decryption branch from 0e31a93 to ae90cf3 Compare October 16, 2020 07:58
@Patrik-Stas Patrik-Stas requested a review from mirgee October 17, 2020 13:42
mirgee
mirgee suggested changes Oct 19, 2020
View reviewed changes
libvcx/src/aries/handlers/connection/agent_info.rs Outdated Show resolved Hide resolved
libvcx/src/api/utils.rs Outdated Show resolved Hide resolved
libvcx/src/aries/handlers/connection/inviter/state_machine.rs Outdated Show resolved Hide resolved
libvcx/src/aries/mod.rs Outdated Show resolved Hide resolved
libvcx/src/aries/mod.rs Outdated Show resolved Hide resolved
libvcx/src/aries/mod.rs Outdated Show resolved Hide resolved
libvcx/src/aries/mod.rs Outdated Show resolved Hide resolved
libvcx/src/aries/utils/encryption_envelope.rs Show resolved Hide resolved
libvcx/src/aries/handlers/connection/agent_info.rs Outdated Show resolved Hide resolved
@Patrik-Stas
Delete legacy decryption code, remove duplicate test
c4bf630 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Simplify decryption and payload related code
3455209 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Remove unused code
221aef3 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Refactor message unpacking
f0a80ff 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Deprecate vcx_messages_download, rename download_messages to download…
1e18e1d 
…_messages_noauth

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Delete unused functions download_agent_messages, get_ref_msg
46c56a3 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
When decoding connection message, verify sender vk, refactoring
e788563 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Rename methods which dont authenticate decrypted messages
31f2471 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Refactor message decryption, assure credential/proof protocol use aut…
1a5c9fa 
…henticated messages

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Fix failing tests
1ef12f9 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Add auth_unpack tests, remove printlncleanup
abcf125 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the cleanup/legacy-decryption branch from 9267821 to abcf125 Compare October 19, 2020 17:41
@Patrik-Stas Patrik-Stas requested a review from mirgee October 19, 2020 19:31
@Patrik-Stas
Copy link
Contributor Author

@mirgee great points, addressed, ready for re-review

@mirgee mirgee merged commit 7385e78 into master Oct 20, 2020
@mirgee mirgee deleted the cleanup/legacy-decryption branch October 20, 2020 07:12
@Patrik-Stas Patrik-Stas mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirgee mirgee mirgee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Patrik-Stas @codecov-io @mirgee