Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering API to filter proof requests by issuer-selected proof request name #132

Merged
merged 5 commits into from
Oct 12, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 9, 2020

... and use it in integration tests.

@mirgee mirgee force-pushed the filtering/proof-requests-by-name branch from 725d2eb to 76646cd Compare October 9, 2020 14:53
@mirgee mirgee changed the base branch from hotfix/double-issuance to master October 9, 2020 14:55
@mirgee mirgee force-pushed the filtering/proof-requests-by-name branch from 76646cd to e920de2 Compare October 9, 2020 14:56
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #132 into master will increase coverage by 0.03%.
The diff coverage is 63.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   50.79%   50.82%   +0.03%     
==========================================
  Files         150      152       +2     
  Lines       22757    22826      +69     
  Branches     6017     6043      +26     
==========================================
+ Hits        11559    11601      +42     
- Misses       7639     7645       +6     
- Partials     3559     3580      +21     
Flag Coverage Δ
#unittests 50.82% <63.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/mod.rs 30.00% <ø> (ø)
libvcx/src/aries/handlers/connection/agent_info.rs 66.66% <ø> (ø)
libvcx/src/aries/mod.rs 8.67% <0.00%> (ø)
libvcx/src/disclosed_proof.rs 67.51% <50.00%> (ø)
libvcx/src/filters.rs 57.50% <57.50%> (ø)
libvcx/src/api/filters.rs 63.15% <63.15%> (ø)
...aries/handlers/proof_presentation/prover/prover.rs 48.11% <66.66%> (+2.02%) ⬆️
libvcx/src/lib.rs 33.39% <85.71%> (-0.10%) ⬇️
libvcx/src/api/disclosed_proof.rs 44.29% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98998a1...a5e1617. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
…quest_messages

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the filtering/proof-requests-by-name branch from 418ac69 to 7d3c13a Compare October 12, 2020 11:40
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the filtering/proof-requests-by-name branch from 7d3c13a to a5e1617 Compare October 12, 2020 11:41
@Patrik-Stas Patrik-Stas merged commit ad65593 into master Oct 12, 2020
@Patrik-Stas Patrik-Stas deleted the filtering/proof-requests-by-name branch October 12, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants