Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Implement Resolver for did:jwk #1290 #1299

Merged
merged 8 commits into from
Dec 3, 2024
Merged

(feat) Implement Resolver for did:jwk #1290 #1299

merged 8 commits into from
Dec 3, 2024

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Oct 18, 2024

Closes #1290

Implementation of DidJwk, which pretty much identical to the style of DidKey https://github.com/hyperledger/aries-vcx/blob/main/did_core/did_methods/did_key/src/lib.rs . This provides an easy way to map from a Key into a DidJwk etc.

Implements a DidResolvable for did-jwk method, which utilizes the did-jwk spec

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn
Copy link
Contributor Author

gmulhearn commented Nov 21, 2024

FWIW, Anonyome was able to consume this successfully. including testing against processing/resolving credo openid4vc issuer did:jwk's and credo processing our holder did:jwk's (derived from Key with DidJwk)

Copy link
Contributor

@lukewli-anonyome lukewli-anonyome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests passed.

@gmulhearn gmulhearn merged commit f5f63a0 into main Dec 3, 2024
17 checks passed
@gmulhearn gmulhearn deleted the gm/did-jwk-res branch December 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Resolver for did:jwk DidResolvable
2 participants