Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor agent-core, publish as package, add signing tests #129

Merged
merged 16 commits into from
Oct 13, 2020
Merged

Refactor agent-core, publish as package, add signing tests #129

merged 16 commits into from
Oct 13, 2020

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

@Patrik-Stas Patrik-Stas force-pushed the agent-node-as-package branch from f4bb146 to a195be4 Compare October 7, 2020 17:18
@codecov-io
Copy link

codecov-io commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #129 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   50.79%   50.80%           
=======================================
  Files         150      150           
  Lines       22757    22757           
  Branches     6017     6017           
=======================================
+ Hits        11559    11561    +2     
+ Misses       7639     7635    -4     
- Partials     3559     3561    +2
Flag Coverage Δ
#unittests 50.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/lib.rs 33.54% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98998a1...27ef177. Read the comment docs.

@Patrik-Stas Patrik-Stas force-pushed the agent-node-as-package branch 3 times, most recently from 3d481db to 8d50e4b Compare October 9, 2020 11:58
mirgee
mirgee suggested changes Oct 9, 2020
View reviewed changes
agents/node/vcxagent-core/src/agent/service-cred-holder.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/demo/alice.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/src/agent/service-connections.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/src/agent/service-connections.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/src/agent/service-connections.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/src/agent/service-cred-holder.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/test/utils/alice.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/demo/alice.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/demo/alice.js Outdated Show resolved Hide resolved
agents/node/vcxagent-core/src/agent/service-ledger-creddef.js Outdated Show resolved Hide resolved
@Patrik-Stas Patrik-Stas force-pushed the agent-node-as-package branch from a3d37fe to f704cea Compare October 9, 2020 19:51
@Patrik-Stas Patrik-Stas requested a review from mirgee October 10, 2020 10:45
@Patrik-Stas Patrik-Stas changed the title Refactore agent-core, publish as package, add signing tests Refactor agent-core, publish as package, add signing tests Oct 10, 2020
@Patrik-Stas Patrik-Stas force-pushed the agent-node-as-package branch 2 times, most recently from d79b84b to 2697ac5 Compare October 10, 2020 20:58
mirgee
mirgee reviewed Oct 12, 2020
View reviewed changes
libvcx/src/lib.rs Outdated Show resolved Hide resolved
@Patrik-Stas
Refactor agent-core
5b69cd1
@Patrik-Stas
Refactor agent-core and dependent code
5e718e3 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Add sign/verify nodejs integration test
15e0575 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Add agent-core npmjs publishing
a3ce932 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Skip batch_revocation test, fix nodejs integration tests
b6177d2 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Fix revocation integration test
46818a1 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Adjust nodejs integration tests, vcxagent-core improvements, adjust ci
e21d478 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Use scoped package for vcxagent-core
ad5c63f 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Refactor vcxagent-core
3f22def 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Unify vcxagent-core api style
5dc26a8 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Update vcxagent-cli
1eb90f4 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Specify node-vcx-wrapper as peer dependency of vcxagent-core
f6fa3b3
@Patrik-Stas
Adjust dependencies
6903909 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Cleanup per code review
c0de61c 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Remove notion of protocol_type from vcxagent, improve proof generation
5269622 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas
Refactor vcxagent-core
7ff4af4 
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the agent-node-as-package branch from c7975db to 7ff4af4 Compare October 12, 2020 13:32
@Patrik-Stas Patrik-Stas requested a review from mirgee October 13, 2020 07:50
@mirgee mirgee merged commit 2820502 into master Oct 13, 2020
@mirgee mirgee deleted the agent-node-as-package branch October 13, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirgee mirgee Awaiting requested review from mirgee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Patrik-Stas @codecov-io @mirgee