fix: allow agent wallet re-creation #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1311f8 to
9a29c94
Compare
Signed-off-by: Pritam Singh <pkspritam16@gmail.com>
9a29c94 to
575dd92
Compare
gmulhearn
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM. It's a little bit invisible/non-obvious that the behaviour of build_indy_wallet is to "idempotently create and open" the wallet. But this error handling fits to that behaviour (ignore re-initializing the link secret).
Also as a note/warning: the aries-vcx-agent is not meant for production use. i believe it's primary use case currently is for testing against other aries implementations in the AATH. Hopefully this is somewhat obvious by the amount of dangerous unwraps that are in these functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.