Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard UnpackMessageOutput struct until finally needing to transform. #1002

Merged

Conversation

nain-F49FF806
Copy link
Member

As suggested in review of #992

Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
@nain-F49FF806 nain-F49FF806 force-pushed the nain/basewallet-deprecate-unpack_message_to_string branch from bfa96b1 to ea89152 Compare September 27, 2023 15:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #1002 (ea89152) into main (ac35fdd) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   30.00%   30.01%   +0.01%     
==========================================
  Files         416      416              
  Lines       26929    26926       -3     
  Branches     5244     5244              
==========================================
+ Hits         8080     8082       +2     
+ Misses      16653    16650       -3     
+ Partials     2196     2194       -2     
Flag Coverage Δ
unittests-aries-vcx 30.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aries_vcx/src/common/signing.rs 51.85% <ø> (+2.72%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@Patrik-Stas Patrik-Stas merged commit d8e7602 into main Sep 28, 2023
@Patrik-Stas Patrik-Stas deleted the nain/basewallet-deprecate-unpack_message_to_string branch September 28, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants