Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github actions warnings #1092

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix github actions warnings #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-llvm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
mac-intel:
name: Mac Intel
needs: create
runs-on: macos-latest
runs-on: macos-11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being pedantic. You did not say anything about this in your PR summary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI output gives a whole bunch of warnings, see https://github.com/hyperledger/solang/actions/runs/3628240205

One of those warnings is:

macOS-latest pipelines will use macOS-12 soon. For more details, see https://github.com/actions/runner-images/issues/6384

So this fixes the warning by ensuring we continue to use macOS-11 for building. The warning goes away and we remain compatible with macOS 11.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already using MacOS 13, so we should change the pipeline to 12 soon!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ensure that we are compatible with the oldest possible version we can support (without much effort). Why move to 12? Apple have good binary compatibility.

steps:
- run: git clone --depth 1 --branch solana-rustc/13.0-2021-08-08 https://github.com/solana-labs/llvm-project.git
- name: Install Ninja
Expand Down
18 changes: 3 additions & 15 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
with:
profile: minimal
default: true
toolchain: 1.63.0
- uses: dtolnay/rust-toolchain@1.63.0
- run: git clone --depth 1 --branch solana-rustc/13.0-2021-08-08 https://github.com/solana-labs/llvm-project.git
# We may not have enough space to compile llvm, see https://github.com/actions/virtual-environments/issues/326
working-directory: C:\
Expand Down Expand Up @@ -152,11 +148,7 @@ jobs:
uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.63.0
default: true
profile: minimal
- uses: dtolnay/rust-toolchain@1.63.0
- run: git clone --depth 1 --branch solana-rustc/13.0-2021-08-08 https://github.com/solana-labs/llvm-project.git
- name: Install Ninja
uses: llvm/actions/install-ninja@main
Expand Down Expand Up @@ -201,11 +193,7 @@ jobs:
uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.63.0
default: true
profile: minimal
- uses: dtolnay/rust-toolchain@1.63.0
- run: git clone --depth 1 --branch solana-rustc/13.0-2021-08-08 https://github.com/solana-labs/llvm-project.git
- name: Install Ninja
uses: llvm/actions/install-ninja@main
Expand Down
27 changes: 7 additions & 20 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,8 @@ jobs:
run: unzip c:\llvm.zip -d c:/
- name: Add LLVM to Path
run: echo "c:\llvm13.0\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8
- uses: actions-rs/toolchain@v1
- uses: dtolnay/rust-toolchain@1.63.0
with:
profile: minimal
toolchain: 1.63.0
default: true
components: clippy
# We run clippy on Linux in the lint job above, but this does not check #[cfg(windows)] items
- name: Run cargo clippy
Expand All @@ -135,11 +132,7 @@ jobs:
uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.63.0
default: true
profile: minimal
- uses: dtolnay/rust-toolchain@1.63.0
- name: Get LLVM
run: curl -L --output llvm13.0-mac-arm.tar.xz https://github.com/hyperledger/solang/releases/download/v0.2.0/llvm13.0-mac-arm.tar.xz
- name: Extract LLVM
Expand All @@ -157,17 +150,13 @@ jobs:

mac-intel:
name: Mac Intel
runs-on: macos-latest
runs-on: macos-11
steps:
- name: Checkout sources
uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.63.0
default: true
profile: minimal
- uses: dtolnay/rust-toolchain@1.63.0
- name: Get LLVM
run: wget -q -O llvm13.0-mac-intel.tar.xz https://github.com/hyperledger/solang/releases/download/v0.2.0/llvm13.0-mac-intel.tar.xz
- name: Extract LLVM
Expand All @@ -185,7 +174,7 @@ jobs:

mac-universal:
name: Mac Universal Binary
runs-on: macos-latest
runs-on: macos-11
needs: [mac-arm, mac-intel]
steps:
- uses: actions/download-artifact@master
Expand Down Expand Up @@ -353,10 +342,8 @@ jobs:
- run: npm run compile
working-directory: ./vscode
- name: Run headless test
uses: GabrielBB/xvfb-action@v1
with:
working-directory: ./vscode
run: npm test
run: xvfb-run npm test
working-directory: ./vscode
- run: npm install -g vsce
working-directory: ./vscode
- run: vsce package
Expand Down