Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce fee receiver #5323

Closed
wants to merge 4 commits into from

Conversation

aoyako
Copy link
Contributor

@aoyako aoyako commented Feb 22, 2025

This PR adds the possibility to set up parts of fee payment configuration (account and asset). [#5315]

The isi Declare is added to differentiate fee configuration from Register and SetParameter.

Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako self-assigned this Feb 22, 2025
@aoyako aoyako marked this pull request as draft February 22, 2025 16:53
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Feb 22, 2025
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako marked this pull request as ready for review February 23, 2025 08:33
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@mversic
Copy link
Contributor

mversic commented Feb 24, 2025

I didn't think we'll introduce a new ISI for this. At first I thought that it should be a configuration value and not modifiable after deployment. But I just remembered of a different suggestion. I think the fee account should be defined in the executor.wasm. Because the fee calculation could be implemented completely as a subpart of the executor and in that regard pluggable. To update/modify fee calculation or the fee recipient one would just upgrade executor. Using executor is also interesting because it has a potential of being a non-breaking change

I think we are moving in a wrong direction with this PR. We need to start working on plugging this into executor

@s8sato
Copy link
Contributor

s8sato commented Feb 25, 2025

I guess the fee receiver can be defined in genesis, and the calculation logic can be in a pre-commit trigger

@mversic
Copy link
Contributor

mversic commented Feb 25, 2025

I guess the fee receiver can be defined in genesis, and the calculation logic can be in a pre-commit trigger

But why would it be defined in genesis. It can also be defined in executor

@aoyako aoyako closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants