Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(satp-hermes): README Update and Smart Contract documentation #3766

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

LordKubaya
Copy link
Contributor

@LordKubaya LordKubaya commented Feb 13, 2025

  • Smart contract documentation
  • README updated with the new implementation

The old PR became out of sync so it was necessary to create a new one.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@LordKubaya LordKubaya changed the title documentation(satp-hermes): README Update and Smart Contract documentation docs(satp-hermes): README Update and Smart Contract documentation Feb 13, 2025
Signed-off-by: Carlos Amaro <carlosrscamaro@tecnico.ulisboa.pt>
@RafaelAPB RafaelAPB merged commit f50ddf2 into hyperledger-cacti:satp-dev Feb 13, 2025
9 of 10 checks passed
@LordKubaya LordKubaya deleted the document branch February 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants