Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(custom-checks): add check to ensure all packages are public scoped #3762

Conversation

adrianbatuto
Copy link
Contributor

Primary Changes

  1. Added check-pkg-json-public.ts to check if all package.json files in the repo are public

Fixes #3666

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
----------------
1. Added check-pkg-json-public.ts to check if all package.json files in the repo are public

Fixes hyperledger-cacti#3666

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
@outSH
Copy link
Contributor

outSH commented Feb 14, 2025

This duplicated the work done in #3714 where I check consistentcy of all package.json fields, so I'd vote on closing it :(

@jagpreetsinghsasan
Copy link
Contributor

Closing this PR due to duplication of efforts (lack of communication and assignment of the ticket #3666)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(custom-checks): add check to ensure all packages are public scoped
3 participants