Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fabric): refactor jest test negative test cases #3735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianbatuto
Copy link
Contributor

@adrianbatuto adrianbatuto commented Feb 3, 2025

Primary Changes

  1. Refactored negative test cases in:
    -fabric-watch-blocks-v1-endpoint.test.ts
    -fabric-watch-blocks-delegated-sign-v1-endpoint.test.ts
    -identity-client.test.ts

Fixes #3472

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
----------------
1. Refactored negative test cases in:
   -fabric-watch-blocks-v1-endpoint.test.ts
   -fabric-watch-blocks-delegated-sign-v1-endpoint.test.ts
   -identity-client.test.ts

Fixes hyperledger-cacti#3472

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianbatuto LGTM, thank you!

@hyperledger-cacti/cacti-maintainers Please take a look at this when you get the chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(fabric): refactor jest test negative test cases
4 participants