Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dast): ccp, sshconfig missing #3705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raynatopedrajeta
Copy link
Contributor

@raynatopedrajeta raynatopedrajeta commented Dec 18, 2024

Primary Changes

  1. Fix the issue on plugin-ledger-connector-fabric that
    throws an error when there is no sshConfig available.

Fixes #3671

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch 3 times, most recently from 85013e4 to 4048f3e Compare December 26, 2024 09:14
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch 26 times, most recently from 3bee9e8 to 9de9c66 Compare January 10, 2025 02:39
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch 8 times, most recently from 956d7f7 to 5ba0d22 Compare January 10, 2025 03:47
@raynatopedrajeta raynatopedrajeta marked this pull request as ready for review January 10, 2025 06:31
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch from 612559d to 2d7bd7d Compare February 13, 2025 03:18
Primary Changes
----------------
1. Fix the issue on plugin-ledger-connector-fabric that
 throws an error when there is no sshConfig available.

Fixes hyperledger-cacti#3671

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@jagpreetsinghsasan
Copy link
Contributor

All good from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dast): ccp, sshconfig missing
3 participants