docs(examples/discounted-asset-trade): fix rendering of docs on website

[rajat-dlt]

fix: Documentation fixed for cactus-example-discounted-asset-trade
At present, the documentation on the GitHub page isn't rendering correctly, and there are issues with numbering. Therefore, adjustments have been made to rectify these issues and ensure that the documentation functions as intended.

Signed-off-by: Rajat Sharma rajat16.sharma@ril.com

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[rajat-dlt]

@petermetz Does this look fine or should I make any further changes in this ?

[petermetz]

@rajat-dlt Thank you very much for this improvement! LGTM with comments (nit-picks):

1. It's hard to untangle the actual changes from the white-space changes, could you please remove the white-space changes from the diff?
   If there are formatting issues it's OK to submit a separate pull request that includes only white-space and formatting changes but not logical changes. It's just not good to mix the two because then the review becomes much harder.
   For last, if the white-space changes are the fix then it's OK, but please let me know just to be sure.
2. Please change the commit message and the PR title to something that doesn't qualify this as a production bug (the fix scope is reserved for problems that are affecting the software running in production). So my recommendation is to change it to docs(examples/discounted-asset-trade): fix rendering of docs on website

[outSH]

@rajat-dlt Also, please use prettier to format changed file according to root config ./.prettierrc.js

[rajat-dlt]

@petermetz ,

1. The changes are the whitespaces and at the last one extra ``` that had to be removed.

2. Updated the commit message, thanks for helping me out with this.

3. @outSH resolved all the prettier issues in the file. Thanks for suggesting that.

Let me know if any further changes are required.

[petermetz]

@rajat-dlt We are getting closer but there are still some things:

1. You've pushed a second commit, please squash them together so that the pull request contains only a single commit.
2. You haven't amended the git commit message, just edited the GitHub PR title but they are separate things:
   

If you need any help with the git mechanics you can also join our daily pair programming call on the Hyperledger Discord server that runs at 10 AM, Pacific Time on weekdays: https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls
There you can share your screen if necessary and I can help you with the details!

[rajat-dlt]

@petermetz,
I've tried to squash and merge both the commits into 1. Hopefully this should be fine, otherwise I'll join the call to get this issue rectified. Thanks a lot for helping me so much with this.

I was expecting from the portal all the commits that are made and squashed and merged into 1 commit. Thus I improved the description here and then went on to make improvements by making multiple commits in the same PR. Apologies for the oversight.

[petermetz]

@petermetz, I've tried to squash and merge both the commits into 1. Hopefully this should be fine, otherwise I'll join the call to get this issue rectified. Thanks a lot for helping me so much with this.

I was expecting from the portal all the commits that are made and squashed and merged into 1 commit. Thus I improved the description here and then went on to make improvements by making multiple commits in the same PR. Apologies for the oversight.

@rajat-dlt No worries, glad I could help! 2 things:

1. You pushed a merge commit so now there are 2 commits in the log once again. Please squash them together when you get the chance!
2. Next time after you updated the pull request please re-request the review otherwise this doesn't show up on my to-do list (I query the pull requests based on which one requires my review)

[rajat-dlt]

@petermetz ,
Fixed the changes, was facing issues while squashing the commits initially so fixed the issues and pushed all the changes together in one commit.

[rajat-dlt]

@outSH @petermetz ,
This PR is still not merged. Is there anything I should do further on this.

[outSH]

@rajat-dlt All good from my side, we're waiting for Peter approval :)

[petermetz]

@outSH @petermetz , This PR is still not merged. Is there anything I should do further on this.

@rajat-dlt Correct. We try to review everything as soon as possible, but it can easily take a few days. With that said, it's looking good now, thank you for the contribution!

[rajat-dlt]

Closes issue #3335 .