Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-besu): migrate v21-invoke-contract.test.ts to Jest #2951

Conversation

petermetz
Copy link
Contributor

  1. No other changs in the test case - just what was strictly necessary
    to make it work with Jest.
  2. Also updated the configuration files of the test runnres in the CI
    so that the test case gets ignored by tape and included by Jest
    (the oppositve was true/necessary prior to this change)

[skip ci]

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I will wait for these jest migrations to be merged because I am adding/modifying these test cases to address #963 )

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I will wait for these jest migrations to be merged because I am adding/modifying these test cases to address #963 )

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. No other changs in the test case - just what was strictly necessary
to make it work with Jest.
2. Also updated the configuration files of the test runnres in the CI
so that the test case gets ignored by tape and included by Jest
(the oppositve was true/necessary prior to this change)

[skip ci]

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the test-connector-besu-migrate-to-jest-v12-invoke-contract-test-ts branch from 2e2d651 to 6438b58 Compare December 15, 2023 21:03
@petermetz petermetz merged commit 53c71de into hyperledger-cacti:main Dec 15, 2023
@petermetz petermetz deleted the test-connector-besu-migrate-to-jest-v12-invoke-contract-test-ts branch December 15, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants