Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fabric): serialization of ccp and sshconfig #3577

Closed
jagpreetsinghsasan opened this issue Oct 8, 2024 · 0 comments · Fixed by #3578
Closed

feat(fabric): serialization of ccp and sshconfig #3577

jagpreetsinghsasan opened this issue Oct 8, 2024 · 0 comments · Fixed by #3578
Assignees
@jagpreetsinghsasan
Labels
enhancement New feature or request Fabric

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to enable serialization of connection profile and sshconfig as base64 encoded strings, so that we can pass these complicated objects easily while initializing the fabric connector over api-server.
This task is related to #3408 (ease of doing api calls)

Acceptance Criteria

The new feature shouldn't prevent the existing functionality to work (i.e. passing the sshconfig and connectionProfile in the usual way)
@jagpreetsinghsasan jagpreetsinghsasan added enhancement New feature or request Fabric labels Oct 8, 2024
@jagpreetsinghsasan jagpreetsinghsasan self-assigned this Oct 8, 2024
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 8, 2024
feat(fabric): serialization of ccp and sshconfig
f3c02d4 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Oct 8, 2024
Merged
5 tasks
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 8, 2024
feat(fabric): serialization of ccp and sshconfig
a346e83 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 10, 2024
feat(fabric): serialization of ccp and sshconfig
4eec642 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 21, 2024
feat(fabric): serialization of ccp and sshconfig
816d14f 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 21, 2024
feat(fabric): serialization of ccp and sshconfig
f6779c6 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 29, 2024
feat(fabric): serialization of ccp and sshconfig
21f4394 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Nov 28, 2024
feat(fabric): serialization of ccp and sshconfig
ea2f752 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 1, 2024
@petermetz
feat(fabric): serialization of ccp and sshconfig
0a5c4c7 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 2, 2024
feat(fabric): serialization of ccp and sshconfig
362abf8 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 2, 2024
feat(fabric): serialization of ccp and sshconfig
3c61af7 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Dec 2, 2024
@petermetz
feat(fabric): serialization of ccp and sshconfig
2a871a2 
    Primary Changes
    ---------------
    1. sshConfig and connectionProfile can now be passed
       as base64 encoded strings

    Changes required to incorporate 1)
    ---------------------------------
    2. Added sshConfigBase64Encoded and
       connectionProfileBase64encoded properties
       to IPluginLedgerConnectorFabricOptions
    3. Added necessary FabricConnector class variables
    4. Added a new testcase to demonstrate
       the same
    5. Updated an implementation which fetches
       sshConfig from class variable

Fixes hyperledger-cacti#3577

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
enhancement New feature or request Fabric
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fabric): serialization of ccp and sshconfig jagpreetsinghsasan/cactus
1 participant
@jagpreetsinghsasan