Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3565

Closed
petermetz opened this issue Sep 30, 2024 · 2 comments · Fixed by #3576
Closed

test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3565

petermetz opened this issue Sep 30, 2024 · 2 comments · Fixed by #3576
Assignees
@aldousalvarez
Labels
Besu Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
vT.B.D

Comments

@petermetz
Copy link
Contributor

Description

The task is to migrate a specific test case (relative path based below) to Jest from TAP:
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

An example pull request showing how these changes are to be done. Pay attention to the config file changes and the coding style of imports, describe() calls, it()/test() calls, the location of the variables storing the environment specific configuration that is created at runtime during the test execution, etc.

The example PR to use as a reference: https://github.com/hyperledger/cacti/pull/3206/files

Acceptance Criteria

  1. Test is only using Jest for assertions.
  2. Config files updated (.taprc, ci.yaml, jest config, etc) so that the test has no hardcoded references to it in these files and instead gets picked up by the correct glob of the test job in ci.yaml related to the package housing the test.
  3. Test is passing
  4. The way the changes were done to the test case matches all the established patterns. See example PR linked above for the patterns of refactoring.
@petermetz petermetz added Besu Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc. P4 Priority 4: Low labels Sep 30, 2024
@petermetz petermetz added this to the vT.B.D milestone Sep 30, 2024
@suumona
Copy link

suumona commented Oct 3, 2024

Hi @petermetz, I am working on this test file and currently its under internal evaluation

@petermetz
Copy link
Contributor Author

@suumona This one seems taken, could you pick another one?

aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 8, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
9531cf3 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@aldousalvarez aldousalvarez mentioned this issue Oct 8, 2024
Merged
5 tasks
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 8, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
223b741 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 8, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
1b42cb7 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 8, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
e746fe1 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 9, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
befd829 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@zondervancalvez zondervancalvez moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Oct 9, 2024
petermetz pushed a commit to aldousalvarez/cactus that referenced this issue Oct 18, 2024
@aldousalvarez @petermetz
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
381798d 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
petermetz pushed a commit to aldousalvarez/cactus that referenced this issue Oct 18, 2024
@aldousalvarez @petermetz
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
f7cae77 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 21, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
a20b7f4 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 22, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
1169aa5 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 22, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
463619e 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 22, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
0c71c1d 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Oct 22, 2024
@aldousalvarez
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction…
f4e6b9a 
…-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes hyperledger-cacti#3565

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Cacti_Scrum_Project_v2_Release Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldousalvarez aldousalvarez

Labels
Besu Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
vT.B.D
Development

Successfully merging a pull request may close this issue.

test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint aldousalvarez/cactus
3 participants
@petermetz @aldousalvarez @suumona