Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(sync-ts-config): integrating the weaver packages to the monorepo build #3366

Open
ruzell22 opened this issue Jun 28, 2024 · 2 comments
Open

build(sync-ts-config): integrating the weaver packages to the monorepo build #3366

ruzell22 opened this issue Jun 28, 2024 · 2 comments
Assignees
@ruzell22
Labels
good-first-issue-100-introductory javascript Pull requests that update Javascript code Weaver Tasks related to the future of Cactus & Weaver together.

Comments

@ruzell22
Copy link
Contributor

Description

The sync-ts-config script has ignore paths that are weaver related for missing tsconfig.json file when executing yarn run sync-ts-config from the command line after having yarn run configure successfully on the main branch.

The 4 paths are:
-/packages/cacti-plugin-weaver-driver-fabric/
-/weaver/common/protos-js/
-/weaver/samples/besu/simpleasset/
-/weaver/samples/besu/simplestate/

Related to: #3069

Acceptance Criteria

  1. Script in question runs fine after integrating of packages and removing the added ignore paths.
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jun 28, 2024
@ruzell22
fix(sync-ts-config): fix no such file or directory tsconfig.json
cdac4a8 
Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script
will run successfully

Related to: hyperledger-cacti#3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@ruzell22 ruzell22 mentioned this issue Jun 28, 2024
Merged
5 tasks
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jun 28, 2024
@ruzell22
fix(sync-ts-config): fix no such file or directory tsconfig.json
9d98810 
Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script
will run successfully

Fixes: hyperledger-cacti#3069
Related to: hyperledger-cacti#3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan added Weaver Tasks related to the future of Cactus & Weaver together. good-first-issue-100-introductory javascript Pull requests that update Javascript code labels Jul 3, 2024
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 4, 2024
@ruzell22
build(sync-ts-config): fix no such file or directory protos-js/tsconf…
2c3286b 
…ig.json

Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script will run successfully

Fixes: hyperledger-cacti#3069
Related to: hyperledger-cacti#3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
petermetz pushed a commit to ruzell22/cactus that referenced this issue Jul 5, 2024
@ruzell22 @petermetz
build(sync-ts-config): fix no such file or directory protos-js/tsconf…
9306ed5 
…ig.json

Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script will run successfully

Fixes: hyperledger-cacti#3069
Related to: hyperledger-cacti#3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
petermetz pushed a commit that referenced this issue Jul 5, 2024
@ruzell22 @petermetz
build(sync-ts-config): fix no such file or directory protos-js/tsconf…
29ec45c 
…ig.json

Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script will run successfully

Fixes: #3069
Related to: #3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@ruzell22
Copy link
Contributor Author

ruzell22 commented Jul 9, 2024

Hello @VRamakrishna , I would like to ask if there are tsconfig.json files for /common/protos-js, /samples/besu/simpleasset, and /samples/besu/simplestate that are not in that base folder but inside another folder? I am trying to do this solution #3367 (comment) for them as well. I have tried it for /packages/cacti-plugin-weaver-driver-fabric and it worked when I ran the yarn run sync-ts-config without having it in ignore path. When I do it, however, a new path has missing tsconfig.json issue when running the script. /core/drivers/fabric-driver/

If there is no specific tsconfig.json file for the mentioned weaver related folders, is there something that I can do to resolve this issue? Thank you.

ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 11, 2024
@ruzell22
build(sync-ts-config): integrating the weaver packages to the monorep…
3692604 
…o build

Primary Changes
---------------

1. Relocated tsconfig file to cacti-plugin-weaver-driver-fabric
2. Added comment regarding the other package not having tsconfig and will
be ignoring till then

Fixes: hyperledger-cacti#3366
Related to: hyperledger-cacti#3069

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@ruzell22 ruzell22 mentioned this issue Jul 11, 2024
Closed
5 tasks
@ruzell22 ruzell22 moved this from In Progress to In review in Cacti_Scrum_Project_v2_Release Jul 11, 2024
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 12, 2024
@ruzell22
build(sync-ts-config): integrating the weaver packages to the monorep…
cdeea85 
…o build

Primary Changes
---------------

1. Relocated tsconfig file to cacti-plugin-weaver-driver-fabric
2. Added comment regarding the other package not having tsconfig and will
be ignoring till then

Fixes: hyperledger-cacti#3366
Related to: hyperledger-cacti#3069

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 15, 2024
@ruzell22
build(sync-ts-config): integrating the weaver packages to the monorep…
9da6ed5 
…o build

Primary Changes
---------------

1. Relocated tsconfig file to cacti-plugin-weaver-driver-fabric
2. Added comment regarding the other package not having tsconfig and will
be ignoring till then

Fixes: hyperledger-cacti#3366
Related to: hyperledger-cacti#3069

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 16, 2024
@ruzell22
build(sync-ts-config): integrating the weaver packages to the monorep…
7706437 
…o build

Primary Changes
---------------

1. Relocated tsconfig file to cacti-plugin-weaver-driver-fabric
2. Added comment regarding the other package not having tsconfig and will
be ignoring till then

Fixes: hyperledger-cacti#3366
Related to: hyperledger-cacti#3069

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jul 22, 2024
@ruzell22
build(sync-ts-config): integrating the weaver packages to the monorep…
0519e22 
…o build

Primary Changes
---------------

1. Updated the ignore paths with the latest cacti clone

Fixes: hyperledger-cacti#3366
Related to: hyperledger-cacti#3069

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@VRamakrishna
Copy link
Contributor

@ruzell22 Sorry, your query passed under my radar. The answer to your question is: no, if the respective folders don't contain a tsconfig.json file, it doesn't exist anywhere else. You are welcome to try and add it (though #3400 didn't really solve the issue) to the various Weaver modules, and we will review it.

@jagpreetsinghsasan jagpreetsinghsasan moved this from In review to Blocked in Cacti_Scrum_Project_v2_Release Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruzell22 ruzell22

Labels
good-first-issue-100-introductory javascript Pull requests that update Javascript code Weaver Tasks related to the future of Cactus & Weaver together.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(sync-ts-config): integrating the weaver packages to the monorepo build ruzell22/cactus
3 participants
@VRamakrishna @jagpreetsinghsasan @ruzell22