Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(typescript): upgrade compiler to v5.x project-wide #2700

Closed
petermetz opened this issue Sep 18, 2023 · 0 comments · Fixed by #2972
Closed

build(typescript): upgrade compiler to v5.x project-wide #2700

petermetz opened this issue Sep 18, 2023 · 0 comments · Fixed by #2972
Assignees
@outSH
Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. javascript Pull requests that update Javascript code Nice-to-Have P4 Priority 4: Low Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Milestone
v2.1.0

Comments

@petermetz
Copy link
Contributor

Description

  1. The compiler needs to be upgraded so that we can take advantage of the latest features that are preventing bugs

Acceptance Criteria

  1. All of the checks are enabled (e.g. we didn't just upgrade with the checks turned off essentially eliminating all the gains of the upgrade in terms of features)
  2. Tests are passing
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers Nice-to-Have dependencies Pull requests that update a dependency file Developer_Experience Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-300-advanced P4 Priority 4: Low javascript Pull requests that update Javascript code labels Sep 18, 2023
@petermetz petermetz added this to the v2.1.0 milestone Sep 18, 2023
@outSH outSH self-assigned this Dec 29, 2023
outSH added a commit to outSH/cactus that referenced this issue Jan 5, 2024
@outSH
build(typescript): upgrade compiler to v5.x project-wide
4ec81c1 
- Upgrade typescript to 5.3.3
- Fix minor compilation issues where problems occurred.

Closes hyperledger-cacti#2700

Depends on hyperledger-cacti#2971

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this issue Jan 5, 2024
Merged
5 tasks
petermetz pushed a commit to outSH/cactus that referenced this issue Jan 19, 2024
@outSH @petermetz
build(typescript): upgrade compiler to v5.x project-wide
fca3ec9 
- Upgrade typescript to 5.3.3
- Fix minor compilation issues where problems occurred.

Closes hyperledger-cacti#2700

Depends on hyperledger-cacti#2971

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this issue Jan 19, 2024
@outSH @petermetz
build(typescript): upgrade compiler to v5.x project-wide
86ac37c 
- Upgrade typescript to 5.3.3
- Fix minor compilation issues where problems occurred.
- Upgraded the protoc-gen-ts package to 0.8.7 which supports
typescript 5.x whereas the previously used version only
supported typescript 4.9 or earlier. This was causing the
yarn codegen script to fail (the code generator script)

Update from Peter: Bumped up protoc-gen-ts to latest versionl.

Closes hyperledger-cacti#2700

Depends on hyperledger-cacti#2971

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Jan 19, 2024
@outSH @petermetz
build(typescript): upgrade compiler to v5.x project-wide
39cc9d2 
- Upgrade typescript to 5.3.3
- Fix minor compilation issues where problems occurred.
- Upgraded the protoc-gen-ts package to 0.8.7 which supports
typescript 5.x whereas the previously used version only
supported typescript 4.9 or earlier. This was causing the
yarn codegen script to fail (the code generator script)

Update from Peter: Bumped up protoc-gen-ts to latest versionl.

Closes #2700

Depends on #2971

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outSH outSH

Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. javascript Pull requests that update Javascript code Nice-to-Have P4 Priority 4: Low Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

build(typescript): upgrade compiler to v5.x project-wide outSH/cactus
2 participants
@petermetz @outSH