Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor api-surface.ts batch #3 #1045

Closed
petermetz opened this issue Jun 16, 2021 · 1 comment · Fixed by #1059
Closed

test: refactor api-surface.ts batch #3 #1045

petermetz opened this issue Jun 16, 2021 · 1 comment · Fixed by #1059

Comments

@petermetz
Copy link
Contributor

Description

  1. Rename the api-surface.ts files to api-surface.test.ts
  2. Refactor the code in the file to use tape-promise and the Typescript types, see example below.

Example

import test, { Test } from "tape-promise/tape";

import * as apiSurface from "../../../main/typescript/public-api";

test("Library can be loaded", (t: Test) => {
  t.ok(apiSurface, "apiSurface truthy OK");
  t.end();
});

List of files for this batch

./packages/cactus-plugin-keychain-vault/src/test/typescript/unit/api-surface.ts
./packages/cactus-test-plugin-ledger-connector-quorum/src/test/typescript/integration/api-surface.ts
./packages/cactus-test-plugin-ledger-connector-quorum/src/test/typescript/unit/api-surface.ts
./packages/cactus-test-tooling/src/test/typescript/integration/api-surface.ts
./packages/cactus-test-tooling/src/test/typescript/unit/api-surface.ts
./packages/cactus-plugin-htlc-eth-besu-erc20/src/test/typescript/integration/api-surface.ts
./packages/cactus-plugin-htlc-eth-besu-erc20/src/test/typescript/unit/api-surface.ts
./packages/cactus-plugin-ledger-connector-quorum/src/test/typescript/integration/api-surface.ts
./packages/cactus-plugin-ledger-connector-quorum/src/test/typescript/unit/api-surface.ts
./packages/cactus-test-plugin-consortium-manual/src/test/typescript/integration/api-surface.ts
./packages/cactus-test-plugin-consortium-manual/src/test/typescript/unit/api-surface.ts

Acceptance Criteria

  1. All files were renamed & refactored from the list above.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @kikoncuo @petermetz @arnab-roy @TonyRowntree @travis-payne @jagpreetsinghsasan @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone @ty-lazar

@twiggins120
Copy link
Contributor

I'm working on this.

twiggins120 added a commit to twiggins120/cactus that referenced this issue Jun 17, 2021
…acti#1045

Fixes hyperledger-cacti#1045

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
twiggins120 added a commit to twiggins120/cactus that referenced this issue Jul 23, 2021
…acti#1045

Fixes hyperledger-cacti#1045

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
petermetz pushed a commit that referenced this issue Jul 24, 2021
Fixes #1045

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
hanxu12 pushed a commit to hanxu12/cactus that referenced this issue Jul 26, 2021
…acti#1045

Fixes hyperledger-cacti#1045

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Signed-off-by: hxlaf <xuhan@lafayette.edu>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
Fixes hyperledger-cacti#1045

Signed-off-by: Tommesha Wiggins <tommesha.wiggins@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants