This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Remove noisy debug logging statement, fix typo #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsulegai
reviewed
Oct 12, 2018
| debug!("Not found: {}", s); | ||
| ErrorCode::NotFound | ||
| } | ||
| DatabaseError::NotFoundError(s) => ErrorCode::NotFound, |
There was a problem hiding this comment.
NotFoundError(s) here can be replaced with NotFoundError(_) ?
There was a problem hiding this comment.
Yeah, you are right, s isn't being used. I will change this.
added 2 commits
October 12, 2018 10:49
This happens when the commit store is asked for a block by batch id or transaction id which happens many times. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
23b2ee7 to
5c7a0bb
Compare
|
Thanks, @arsulegai. Can you re-review? |
agunde406
approved these changes
Oct 15, 2018
aludvik
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.