This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Block Publisher FFI Cleanup #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 3, 2018 08:04
This is more consistent with how these objects are used and cleans up the constructor functions. Signed-off-by: Adam Ludvik <ludvik@bitwise.io>
The type of argument to new() should support non-python executors. Signed-off-by: Adam Ludvik <ludvik@bitwise.io>
The type of argument should support non-python executors. Note that this change requires moving batch observers into state so they can be cloned, since you cannot require `Clone` on a trait object. Signed-off-by: Adam Ludvik <ludvik@bitwise.io>
d9a7fd2 to
d5b2bfe
Compare
agunde406
approved these changes
Oct 3, 2018
boydjohnson
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of (I hope) a few PRs to cleanup some of the FFI and concurrency code in the BlockPublisher and validator in general.