Fixes and improvements for Eclipse branch #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix block explorer links Show toast on recipient balance increase Show toast from self button if wallet not connected Improve sidebar menu scrolling
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jmrossy
commented
Aug 14, 2023
| @@ -110,11 +110,11 @@ export function SideBarMenu({ | |||
| <Image src={CollapseIcon} width={15} height={24} alt="" /> | |||
| </button> | |||
| )} | |||
| <div className="w-full h-full"> | |||
| <div className="w-full bg-blue-500 py-2 px-3.5 text-white tracking-wide rounded-t-sm"> | |||
| <div className="w-full h-full flex flex-col overflow-y-auto"> | |||
There was a problem hiding this comment.
Changes in this file are form a commit I just from Danylo a few minutes ago. I asked him yesterday to improve the scrolling behavior of the sidebar menu. The bottom was getting cut off
nambrot
approved these changes
Aug 14, 2023
| prevRecipientBalance.current.recipientAddress === recipientAddress && | ||
| new BigNumber(balance).gt(prevRecipientBalance.current.balance) | ||
| ) { | ||
| toast.success('Recipient has received funds, transfer complete!'); |
There was a problem hiding this comment.
Should we still set prevRecipientBalance after the toast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Hyperlane explorer link
Fix block explorer links
Show toast on recipient balance increase
Show toast from self button if wallet not connected Improve sidebar menu scrolling
Improve sidebar menu scrolling