Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling errors #5166

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix spelling errors #5166

wants to merge 10 commits into from
+9 −9

Conversation

Pronoss
Copy link

@Pronoss Pronoss commented Jan 14, 2025

  • Fixed currenct to current.
  • Corrected intruction to instruction.
  • Changed Backgroun to Background.
  • Fixed Lifecyle to Lifecycle.
  • Corrected Arguements to Arguments.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ddd646

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jmrossy
jmrossy reviewed Jan 14, 2025
View reviewed changes
typescript/sdk/src/deploy/verify/ContractVerifier.ts Outdated
@@ -366,7 +366,7 @@ export class ContractVerifier {
contractname: `${sourceName}:${input.name}`,
contractaddress: input.address,
/* TYPO IS ENFORCED BY API */
constructorArguements: strip0x(input.constructorArguments ?? ''),
constructorArguments: strip0x(input.constructorArguments ?? ''),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

typescript/sdk/src/deploy/verify/types.ts Outdated
@@ -89,7 +89,7 @@ export type FormOptions<Action extends ExplorerApiActions> =
sourceCode: string;
contractname: string;
/* TYPO IS ENFORCED BY API */
constructorArguements?: string;
constructorArguments?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

jmrossy
jmrossy reviewed Jan 17, 2025
View reviewed changes
typescript/sdk/src/deploy/verify/ContractVerifier.ts
@@ -366,7 +366,7 @@ export class ContractVerifier {
contractname: `${sourceName}:${input.name}`,
contractaddress: input.address,
/* TYPO IS ENFORCED BY API */
constructorArguements: strip0x(input.constructorArguments ?? ''),
constructorArguements: strip0x(input.constructorArguements ?? ''),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this constructorArguements and it's related parts unchanged please

typescript/sdk/src/index.ts
@@ -60,7 +60,7 @@ export {
CoreFactories,
coreFactories,
} from './core/contracts.js';
export { HyperlaneLifecyleEvent } from './core/events.js';
export { HyperlaneLifecycleEvent } from './core/events.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the export without fixing the thing it's referring to will break the SDK. Did you try building this before opening your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy left review comments

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@daniel-savu daniel-savu Awaiting requested review from daniel-savu daniel-savu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pronoss @jmrossy