-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add indices to Scraper database so that queries are quicker #5039
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
e8b5607
to
d308ad1
Compare
rust/main/agents/scraper/migration/src/m20230309_000003_create_table_cursor.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance you can test these changes, along with SeaORM v1.1.1, on the RC scraper to make sure all slow queries are being fixed by this - or at least understand why remaining slow queries are happening
rust/main/agents/scraper/migration/src/m20230309_000003_create_table_cursor.rs
Show resolved
Hide resolved
The changes in this particular PR were tested when they were done in production database some time ago. In general, we need to bring back SeaORM 1.1.1 (or the latest version) and test it as well. It would be a separate task, though. |
Just saying that if the purpose of this PR is to fix seaorm 1.1.1 issues, it should be evaluated against seaorm 1.1.1 to make sure they're no longer issues. Otherwise there's no urgency in releasing this |
Description
Add indices to Scraper database so that queries are quicker.
Scraper with SeaORM version 1.1.1 (currently reverted) reported that some queries are running slow. These indices will improve it.
Related issues
Backward compatibility
Yes
Testing
Tested queries with indices on a separate database where full production database backup was restored