Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup caches for merged prs #4429

Closed
wants to merge 7 commits into from
Closed

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Sep 4, 2024

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 710e247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji marked this pull request as ready for review September 4, 2024 15:52
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.22%. Comparing base (88d4c39) to head (710e247).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4429   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         100      100           
  Lines        1412     1412           
  Branches      178      178           
=======================================
  Hits         1034     1034           
  Misses        357      357           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 72.38% <ø> (ø)
isms 78.31% <ø> (ø)
token 88.88% <ø> (ø)
middlewares 77.39% <ø> (ø)


on:
pull_request:
types: [closed, enqueued]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I'm not certain, I assume we still run CI for PRs in the merge queue and that's why it takes so long? in which case does it make sense to clean up the cache when enqueuing a PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just how GHA caches work, that the merge queue cache is derived from the target branch, and is separate to that of the branch being merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once a PR is enqueued, it goes into the merge queue, each PR in the merge queue is effectively a separate gh-readonly branch that can't use the same cache as the PR branch (since they're separate branches)

a big problem atm is we get into a state where the incoming branches should be able to pickup an existing cache but can't because GHA is evicting caches from main super aggressively

Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
@paulbalaji
Copy link
Contributor Author

please pull latest main after #4458 is merged to fix the cli-advanced-e2e test

@paulbalaji paulbalaji marked this pull request as draft September 10, 2024 19:26
@paulbalaji
Copy link
Contributor Author

probs not required after moving to buildjet #4424

@paulbalaji paulbalaji closed this Sep 10, 2024
@paulbalaji paulbalaji deleted the pb/cleanup-cache branch September 10, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants