-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup caches for merged prs #4429
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4429 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 100 100
Lines 1412 1412
Branches 178 178
=======================================
Hits 1034 1034
Misses 357 357
Partials 21 21
|
.github/workflows/cleanup-cache.yml
Outdated
|
||
on: | ||
pull_request: | ||
types: [closed, enqueued] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I'm not certain, I assume we still run CI for PRs in the merge queue and that's why it takes so long? in which case does it make sense to clean up the cache when enqueuing a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just how GHA caches work, that the merge queue cache is derived from the target branch, and is separate to that of the branch being merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once a PR is enqueued, it goes into the merge queue, each PR in the merge queue is effectively a separate gh-readonly branch that can't use the same cache as the PR branch (since they're separate branches)
a big problem atm is we get into a state where the incoming branches should be able to pickup an existing cache but can't because GHA is evicting caches from main
super aggressively
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
c476f42
to
f0c06c7
Compare
please pull latest |
probs not required after moving to buildjet #4424 |
see it in action here: https://github.com/hyperlane-xyz/hyperlane-monorepo/actions/runs/10705157657/job/29679857473?pr=4429#step:3:30