Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: neutron grpc url default; url parsing error message #3466

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Mar 21, 2024

Description

The default neturon grpc url is plaintext but it was using a http prefix so all requests would fail

Drive-by changes

Related issues

Backward compatibility

Testing

@daniel-savu daniel-savu requested a review from tkporter as a code owner March 21, 2024 13:57
Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: aecb518

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #3466 (aecb518) into main (59e89af) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3466   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         16      16           
=====================================
  Misses        16      16           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@daniel-savu daniel-savu merged commit 140e3c4 into main Mar 21, 2024
33 of 34 checks passed
@daniel-savu daniel-savu deleted the dan/neutron-grpc-fix branch March 21, 2024 14:27
yorhodes pushed a commit that referenced this pull request Mar 22, 2024
### Description

The default neturon grpc url is plaintext but it was using a `http`
prefix so all requests would fail

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants