Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IGP oracles #3244

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Update IGP oracles #3244

merged 12 commits into from
Feb 13, 2024

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Feb 9, 2024

Description

Simplify IGP oracle config and deployment by removing multiple storage gas oracles. Update infra to use new IGP configs. Improve IGP deployer logs. Use updated exchange rates. Update 20% margin to apply only when rates are unequal

Drive-by changes

  • Rework ownable logic slightly
  • Add mantapacific to safe addresses

Related issues

Backward compatibility

  • Oracle comparison is now done in igp/core fork tests

Testing

  • CI fork tests
  • manual mainnet deploy

Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: a8d2782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #3244 (a8d2782) into main (dcd78e9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@yorhodes yorhodes requested a review from aroralanuk February 13, 2024 16:50
Copy link
Contributor

@aroralanuk aroralanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

typescript/sdk/src/gas/oracle/types.ts Show resolved Hide resolved
@yorhodes yorhodes merged commit 93f864f into main Feb 13, 2024
23 of 24 checks passed
@yorhodes yorhodes deleted the simplify-igp-oracles branch February 13, 2024 20:08
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Feb 15, 2024
### Description

Simplify IGP oracle config and deployment by removing multiple storage
gas oracles. Update infra to use new IGP configs. Improve IGP deployer
logs. Use updated exchange rates. Update 20% margin to apply only when
rates are unequal

### Drive-by changes

- Rework ownable logic slightly
- Add mantapacific to safe addresses

### Backward compatibility

- Oracle comparison is now done in igp/core fork tests

### Testing

- CI fork tests
- manual mainnet deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants