New polygon gas oracle URLs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(middleware): polygon gas stations * fix: wasm
daniel-savu
approved these changes
Nov 29, 2023
tkporter
added a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Nov 29, 2023
### Description Update to latest ethers-rs (forked) version with hyperlane-xyz/ethers-rs#9 ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility n/a ### Testing Planning to deploy with it, but the ethers-rs version is well tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking gakonst#2479
Sadly we've deviated decently far from upstream so I had to bust out the code scalpel to effectively cherry-pick w/o a bunch of changes. Opened https://github.com/hyperlane-xyz/issues/issues/806 as I think now is probably the time to try to move away from our fork
Motivation
Looks like the old URLs we were using were broken. The way we were consuming this previously gracefully handled errors here to mean that it should just fall back to legacy txs, so we had no issues. But when we moved to using a GasOracleMiddleware, we lost the graceful error handling
Solution
See gakonst#2479
PR Checklist