Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_interface connector option #3076

Open
wants to merge 2 commits into
base: 0.14.x
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add set_interface connector option
hottea773 committed Dec 7, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 13892d44ad63c12965723db5d59d9eea44955384
90 changes: 90 additions & 0 deletions src/client/connect/http.rs
Original file line number Diff line number Diff line change
@@ -81,6 +81,7 @@ struct Config {
reuse_address: bool,
send_buffer_size: Option<usize>,
recv_buffer_size: Option<usize>,
interface: Option<String>,
}

// ===== impl HttpConnector =====
@@ -121,6 +122,7 @@ impl<R> HttpConnector<R> {
reuse_address: false,
send_buffer_size: None,
recv_buffer_size: None,
interface: None,
}),
resolver,
}
@@ -230,6 +232,25 @@ impl<R> HttpConnector<R> {
self
}

/// Sets the value for the `SO_BINDTODEVICE` option on this socket.
///
/// If a socket is bound to an interface, only packets received from that particular
/// interface are processed by the socket. Note that this only works for some socket
/// types, particularly AF_INET sockets.
///
/// On Linux it can be used to specify a [VRF], but the binary needs
/// to either have `CAP_NET_RAW` or to be run as root.
///
/// This function is only available on Android、Fuchsia and Linux.
///
/// [VRF]: https://www.kernel.org/doc/Documentation/networking/vrf.txt
#[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))]
#[inline]
pub fn set_interface<S: Into<String>>(&mut self, interface: S) -> &mut Self {
self.config_mut().interface = Some(interface.into());
self
}

// private

fn config_mut(&mut self) -> &mut Config {
@@ -613,6 +634,14 @@ fn connect(
}
}

#[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))]
// That this only works for some socket types, particularly AF_INET sockets.
if config.interface.is_some() {
socket
.bind_device(config.interface.as_ref().map(|iface| iface.as_bytes()))
.map_err(ConnectError::m("tcp bind interface error"))?;
}

bind_local_address(
&socket,
addr,
@@ -765,6 +794,14 @@ mod tests {
(ip_v4, ip_v6)
}

#[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))]
fn default_interface() -> Option<String> {
pnet_datalink::interfaces()
.iter()
.find(|e| e.is_up() && !e.is_loopback() && !e.ips.is_empty())
.map(|e| e.name.clone())
}

#[tokio::test]
async fn test_errors_missing_scheme() {
let dst = "example.domain".parse().unwrap();
@@ -813,6 +850,58 @@ mod tests {
}
}

// NOTE: pnet crate that we use in this test doesn't compile on Windows
#[cfg(any(target_os = "android", target_os = "fuchsia", target_os = "linux"))]
#[tokio::test]
#[ignore = "setting `SO_BINDTODEVICE` requires the `CAP_NET_RAW` capability (works when running as root)"]
async fn interface() {
use socket2::{Domain, Protocol, Socket, Type};
use std::net::TcpListener;
let _ = pretty_env_logger::try_init();

let interface: Option<String> = default_interface();

let server4 = TcpListener::bind("127.0.0.1:0").unwrap();
let port = server4.local_addr().unwrap().port();

let server6 = TcpListener::bind(&format!("[::1]:{}", port)).unwrap();

let assert_interface_name =
|dst: String,
server: TcpListener,
bind_iface: Option<String>,
expected_interface: Option<String>| async move {
let mut connector = HttpConnector::new();
if let Some(iface) = bind_iface {
connector.set_interface(iface);
}

connect(connector, dst.parse().unwrap()).await.unwrap();
let domain = Domain::for_address(server.local_addr().unwrap());
let socket = Socket::new(domain, Type::STREAM, Some(Protocol::TCP)).unwrap();

assert_eq!(
socket.device().unwrap().as_deref(),
expected_interface.as_deref().map(|val| val.as_bytes())
);
};

assert_interface_name(
format!("http://127.0.0.1:{}", port),
server4,
interface.clone(),
interface.clone(),
)
.await;
assert_interface_name(
format!("http://[::1]:{}", port),
server6,
interface.clone(),
interface.clone(),
)
.await;
}

#[test]
#[cfg_attr(not(feature = "__internal_happy_eyeballs_tests"), ignore)]
fn client_happy_eyeballs() {
@@ -942,6 +1031,7 @@ mod tests {
enforce_http: false,
send_buffer_size: None,
recv_buffer_size: None,
interface: None,
};
let connecting_tcp = ConnectingTcp::new(dns::SocketAddrs::new(addrs), &cfg);
let start = Instant::now();