Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): Remove unused unimplemented! macro. #1183

Merged
merged 1 commit into from
May 22, 2017

Conversation

MJDSys
Copy link
Contributor

@MJDSys MJDSys commented May 19, 2017

This macro isn't used anywhere, std now has an unimplemented macro
if we want to use it, and the nightly compiler now warns that this
unused. This warning is a failure when compiling tests.

This macro isn't used anywhere, std now has an unimplemented macro
if we want to use it, and the nightly compiler now warns that this
unused.  This warning is a failure when compiling tests.
@seanmonstar seanmonstar merged commit 09fe9e6 into hyperium:master May 22, 2017
@seanmonstar
Copy link
Member

Thanks!

I technically had this in hyper's source so that I could add messages to the macro invocations, like unimplemented!("Conn::poll_complete"). I found that immensely useful, and so I've filed a PR to add that functionality to rust proper: rust-lang/rust#42155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants