Revert to intentional nested res ids and pin dependencies #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate nested resource ids
Duplicate directories were removed in #7. The duplication is undesirable but moving away from it poses some potential frustrations for JH users who have workflows that rely on the duplication. So this pr reverts to keep the duplicate directories.
Pin some dependencies
Seems like the Tornado upgrade is necessary --exceptions were being thrown during OVERWRITE of existing resource files.
Version of Mistune and NBConvert have to be chosen carefully
jupyter/nbconvert#1864
NOTE: environment
this PR only tested with
jupyter_server==1.13.1and the env shown in environment.yml which was exported from the conda environment in the "Scientific" image on June 9 2023