Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Improve the media file instance API #1932

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 4, 2024

Abstract

Makes large improvements to the Asset API #1904 by creating a more fluent interface for interacting with media assets. It also removes the media link helper (replacing #1914), now using the Asset API for all media link retrievals. This has the side effect of media files now being required to exist in the project, and that cache busting keys are now consistently added to all media links, and media links will now be qualified using the base URL if set.

Auxiliary Changes

The filesystem facade has been updated to contain the mime type finder.

@caendesilva caendesilva changed the base branch from master to normalize-the-asset-api August 4, 2024 10:32
@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch from 9b66987 to 96b1856 Compare August 4, 2024 10:32
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (620c972) to head (ff18348).
Report is 71 commits behind head on normalize-the-asset-api.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             normalize-the-asset-api    #1932      +/-   ##
=============================================================
- Coverage                     100.00%   99.97%   -0.03%     
- Complexity                      1886     1887       +1     
=============================================================
  Files                            193      193              
  Lines                           4978     4983       +5     
=============================================================
+ Hits                            4978     4982       +4     
- Misses                             0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch from f4b2810 to 5c77557 Compare August 4, 2024 17:36
@caendesilva
Copy link
Member Author

I started adding back support for media files not backed by a file on disk c48a731, but realized that won't make sense, because how would they be used? If they have no contents we have nothing to copy to the output directory.

@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch from 06fd82d to ad58ca7 Compare August 20, 2024 10:48
@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch 4 times, most recently from 24571bf to 5275c9e Compare September 7, 2024 11:51
@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch from 5275c9e to a329652 Compare September 7, 2024 12:47
@caendesilva caendesilva force-pushed the improve-the-media-file-instance-api branch from d4c3a5e to ff18348 Compare September 7, 2024 13:13
@caendesilva caendesilva added WTD Calls What The Diff and removed WTD Calls What The Diff labels Sep 7, 2024
@caendesilva caendesilva marked this pull request as ready for review September 7, 2024 14:45
@caendesilva caendesilva merged commit 0723c8a into normalize-the-asset-api Sep 7, 2024
7 checks passed
@caendesilva caendesilva deleted the improve-the-media-file-instance-api branch September 7, 2024 14:46
caendesilva added a commit that referenced this pull request Sep 8, 2024
…-api

[2.x] Improve the media file instance API
caendesilva added a commit that referenced this pull request Sep 8, 2024
…-api

[2.x] Improve the media file instance API
caendesilva added a commit that referenced this pull request Sep 8, 2024
…-api

[2.x] Improve the media file instance API
@caendesilva caendesilva mentioned this pull request Oct 4, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant