-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Improve the media file instance API #1932
[2.x] Improve the media file instance API #1932
Conversation
9b66987
to
96b1856
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1932 +/- ##
=============================================================
- Coverage 100.00% 99.97% -0.03%
- Complexity 1886 1887 +1
=============================================================
Files 193 193
Lines 4978 4983 +5
=============================================================
+ Hits 4978 4982 +4
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
f4b2810
to
5c77557
Compare
I started adding back support for media files not backed by a file on disk c48a731, but realized that won't make sense, because how would they be used? If they have no contents we have nothing to copy to the output directory. |
06fd82d
to
ad58ca7
Compare
24571bf
to
5275c9e
Compare
This is quite important so I want it properly tested
5275c9e
to
a329652
Compare
d4c3a5e
to
ff18348
Compare
…-api [2.x] Improve the media file instance API
…-api [2.x] Improve the media file instance API
…-api [2.x] Improve the media file instance API
Abstract
Makes large improvements to the Asset API #1904 by creating a more fluent interface for interacting with media assets. It also removes the media link helper (replacing #1914), now using the Asset API for all media link retrievals. This has the side effect of media files now being required to exist in the project, and that cache busting keys are now consistently added to all media links, and media links will now be qualified using the base URL if set.
Auxiliary Changes
The filesystem facade has been updated to contain the mime type finder.