Update monorepo dependencies #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.11.7 to 1.11.8. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.12.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.11.7...1.11.8) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rector/rector](https://github.com/rectorphp/rector) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@1.2.1...1.2.2) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [driftingly/rector-laravel](https://github.com/driftingly/rector-laravel) from 1.2.0 to 1.2.1. - [Release notes](https://github.com/driftingly/rector-laravel/releases) - [Commits](driftingly/rector-laravel@1.2.0...1.2.1) --- updated-dependencies: - dependency-name: driftingly/rector-laravel dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1926 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1766 1766
===========================================
Files 182 182
Lines 4707 4707
===========================================
Hits 4707 4707 ☔ View full report in Codecov by Sentry. |
caendesilva
commented
Jul 31, 2024
| "hyde/monorepo-dev-tools": "*", | ||
| "hyde/realtime-compiler": "*", | ||
| "hyde/testing": "*", | ||
| "jetbrains/phpstorm-attributes": "^1.0", | ||
| "laravel/tinker": "^2.7", | ||
| "pestphp/pest-plugin-type-coverage": "^2.8", | ||
| "pestphp/pest-plugin-type-coverage": "2.x-dev", |
There was a problem hiding this comment.
We need pestphp/pest-plugin-type-coverage@147f8b6 which has not been released yet. Otherwise we get this:
Too few arguments to function PHPStan\Analyser\NodeScopeResolver::__construct(), 26 passed in /home/runner/work/develop/develop/vendor/pestphp/pest-plugin-type-coverage/src/PHPStanAnalyser.php on line 80 and exactly 27 expected
This reverts commit 8e20219.
|
Not sure why we lost so much type coverage... |
This reverts commit 9c00006.
|
Too many incompatibilities, so gave up with the new Psalm version and reverted to the original. |
8259988 to
305a6fc
Compare
caendesilva
added a commit
that referenced
this pull request
Jul 31, 2024
caendesilva
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these needs to be merged together:
Additionally it removes some packages from the monorepo that we haven't used in a long time, and are generally better to install through an isolated setup like a dedicated Composer root or using a Phar: