Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add String method #552

Merged
merged 10 commits into from
Dec 8, 2019
Merged

add String method #552

merged 10 commits into from
Dec 8, 2019

Conversation

mh-cbon
Copy link
Contributor

@mh-cbon mh-cbon commented Nov 24, 2019

it is not automated as i wanted initially, but go stringer is not as useful as i thought, and, i was not feeling to rewrite stringer (yet). anyway, it is done.

@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #552 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #552   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          17       17           
  Lines        2092     2092           
=======================================
  Hits         2052     2052           
  Misses         33       33           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c254d...c5e953f. Read the comment docs.

@deadprogram
Copy link
Member

Hi @mh-cbon thanks for the PR. Took me a minute to realize what this was doing. That was a lot of work!

Only request I have, I am pretty sure that the file contrib/data.yaml is generated by the contrib tests, and probably should not be committed to the repo and also should probably added to the .gitignore files.

What do you think?

@mh-cbon
Copy link
Contributor Author

mh-cbon commented Dec 8, 2019

all done, i also updated with upstream. thank you for the feedback and merging.

@deadprogram
Copy link
Member

Thank you! Now squash/merging.

@deadprogram deadprogram merged commit d624e2c into hybridgroup:dev Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants