Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing now after merging #1015 , only on python 3.6, even though CI was passing with the PR contents. I believe this might have something to do with changes made in #1016 which was merged shortly before. The CI on that one was also passing, but the sdsist installation tests didn't exist then, so I think this failure is a combination of the issues.
Failure:
The error looks like what's described here:
that despite poetry supporting python 3.6, poetry-core had already dropped it. I don't really see how the changes in #1016 affected that, since it didn't change the poetry core version, but I'm attempting to fix it for this one release that we're doing before we drop Python 3.6 in 2.0 soon.