-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next(breaking): Floating Content child
Snippet
#994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 759424d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
child
child
Snippet
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're introducing a breaking change to improve performance and fix issues with floating content components that use Svelte transitions.
Current Behavior & Issue
Our floating
<X.Content>
components currently wrap user content in a positioning div. While this simplifies styling by separating positioning logic from content styles, it creates performance issues when used with Svelte transitions or conditional rendering.The current internal implementation:
When using transitions, this results in:
The key issue is that the wrapper
div
remains in the DOM even when content is hidden, continuously recalculating positions on viewport changes. This creates unnecessary performance overhead, especially with multiple floating components (see Issue #877).New Implementation
To resolve this, we're updating the
child
snippet API for all Floating UI-basedContent
components. The new API provides more granular control over wrapper and content elements:Migration Impact
This is a breaking change that will affect applications using the
child
snippet with Floating UI-basedContent
components inbits-ui@1.0.0-next
. While we understand this may require updates to your code, we're making this change early to minimize the long-term impact as adoption grows beyondbits-ui@0.X
.We recommend encapsulating these components in your own reusable components to minimize the impact of such changes across your application.
Before:
After:
Components Impacted
Combobox
ContextMenu
DatePicker
DateRangePicker
DropdownMenu
LinkPreview
Menubar
Popover
Select
Tooltip