-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: rename Listbox
to Select
and drop old select
#769
Conversation
🦋 Changeset detectedLatest commit: 6b7c78c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Listbox
and replace Select
with its impl.Listbox
to Select
and drop old select
Hey, since Select can now have |
Select
andListbox
are way too similar to be separate components. This just creates confusion, and IMO, the original implementation ofListbox
is much better.This PR replaces the entire
Select
implementation with the currentListbox
implementation + a few additional features to handle typeahead when the trigger is focused, and the content is closed via theitems
prop. We've dropped theListbox
component (if you were using it before, just replaceListbox
withSelect
and the API is the same. If you were using theSelect
, you'll just need to make a few minor changes to get back up and running.Now, users don't need to use an entirely different component/API for "multi-select"; the updated
Select
is capable of both.Additionally, support has been added for auto-filling responses via password managers or otherwise, if you provide the
items
prop and it's atype="single"
Select.Closes #753
Closes #748