Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested focus scope infinite loops #1132

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: nested focus scope infinite loops #1132

merged 3 commits into from
Feb 10, 2025

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Feb 10, 2025

Closes #913

@huntabyte huntabyte added the publish:preview Add to PRs to publish preview packages with `pkg-pr-new` label Feb 10, 2025
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: a45bee1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/bits-ui@1132

commit: a45bee1

Copy link
Contributor

github-actions bot commented Feb 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview a45bee1

@huntabyte huntabyte merged commit 833a653 into next Feb 10, 2025
6 checks passed
@huntabyte huntabyte deleted the fix/913-again branch February 11, 2025 01:29
This was referenced Feb 13, 2025
pavlanovotna pushed a commit to pavlanovotna/bits-ui that referenced this pull request Feb 13, 2025
…homepage

* 'next' of github.com:pavlanovotna/bits-ui: (146 commits)
  Version Packages (next) (huntabyte#1149)
  Version Packages (next) (huntabyte#1147)
  docs: tweak nav menu styles (huntabyte#1148)
  fix: `Checkbox.Group` `onValueChange` not being called (huntabyte#1146)
  docs: combobox (huntabyte#1145)
  Version Packages (next) (huntabyte#1139)
  fix: `Command.Root` `onStateChange` not firing after first mount (huntabyte#1138)
  docs: tailwind config update and style tweaks (huntabyte#1137)
  docs: animation updates (huntabyte#1136)
  docs: navigation menu forceMount prop (huntabyte#1135)
  Version Packages (next) (huntabyte#1134)
  fix: nested focus scope infinite loops (huntabyte#1132)
  fix: tooltip not closing when pointer leaves (huntabyte#1133)
  Version Packages (next) (huntabyte#1128)
  feat: export `computeCommandScore` for use in custom Command filters (huntabyte#1127)
  docs: v1 migration guide (huntabyte#1125)
  Version Packages (next) (huntabyte#1121)
  fix: issues with select/combobox highlighting on mobile (huntabyte#1124)
  fix: focus scoping issues when closing/opening in same action (huntabyte#1123)
  fix: remove logs (huntabyte#1122)
  ...

# Conflicts:
#	sites/docs/src/routes/(main)/+layout.svelte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish:preview Add to PRs to publish preview packages with `pkg-pr-new`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant