fix: avatar image crossorigin

huntabyte · Oct 3, 2024 · 5b01638 · 5b01638
1 parent f7da83a
commit 5b01638
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/.changeset/soft-comics-sort.md b/.changeset/soft-comics-sort.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+fix: ensure `crossorigin` isn't applied to image if it is `undefined` or not passed as a prop
diff --git a/packages/bits-ui/src/lib/bits/avatar/avatar.svelte.ts b/packages/bits-ui/src/lib/bits/avatar/avatar.svelte.ts
@@ -47,7 +47,7 @@ class AvatarRootState {
 		const image = new Image();
 
 		image.src = src;
-		if (crossorigin) image.crossOrigin = crossorigin;
+		if (crossorigin !== undefined) image.crossOrigin = crossorigin;
 		if (referrerPolicy) image.referrerPolicy = referrerPolicy;
 
 		this.loadingStatus.current = "loading";

diff --git a/packages/bits-ui/src/lib/bits/avatar/components/avatar-image.svelte b/packages/bits-ui/src/lib/bits/avatar/components/avatar-image.svelte
@@ -10,7 +10,7 @@
 		child,
 		id = useId(),
 		ref = $bindable(null),
-		crossorigin = "",
+		crossorigin = undefined,
 		referrerpolicy = undefined,
 		...restProps
 	}: ImageProps = $props();

diff --git a/sites/docs/src/hooks.server.ts b/sites/docs/src/hooks.server.ts
@@ -1,10 +1,4 @@
-import { buildDocsIndex } from "$lib/scripts/build-search.js";
-
 export async function handle({ event, resolve }) {
 	const response = await resolve(event);
-
-	response.headers.set("Cross-Origin-Embedder-Policy", "require-corp");
-	response.headers.set("Cross-Origin-Opener-Policy", "same-origin");
-
 	return response;
 }