Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reputation Oracle] refactor: web3service and dependent configs #3115

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

dnechay
Copy link
Contributor

@dnechay dnechay commented Feb 24, 2025

Issue tracking

Part of #3084

Context behind the change

  • removed NetworkConfigService because it violates common approach for config services: they should work only with env vars for simplicity, no custom logic
  • however, the above is not the case for Web3ConfigService.operatorAddress because we can derive this value from PK and avoid having another env var for address
  • added fixtures folder: place where we going to have all generators for test data and some hardcoded stuff when it's necessary to test exact values; later we will get rid of test/constants in favor of this folder
  • start to use fixtures and mock generators in common & utils & also fixed some tests there
  • cleaned up how we use Nest modules:
    • do not export anything from module if it's not imported later
    • no need to import ConfigModule because we have our config exported globally
    • when you import some module, there is no need to pass what it exports in providers list
    • re-arrange imports to go as "libs", "outer modules/tools", "this module stuff"
    • the above step revealed old circular dependency, so fixed it as well

How has this been tested?

  • CI tests pass
  • Run locally; e2e test for auth/web3/signup endpoint to succeed

Release plan

Simply merge

Potential risks; What to monitor; Rollback plan

No

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:07pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:07pm
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:07pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:07pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:07pm

Copy link
Contributor

@Dzeranov Dzeranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnechay dnechay merged commit 3501c19 into develop Feb 27, 2025
12 checks passed
@dnechay dnechay deleted the dnechay/3084-web3 branch February 27, 2025 10:34
@dnechay dnechay mentioned this pull request Feb 27, 2025
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants