-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reputation Oracle] refactor: web3service and dependent configs #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
97e2b6d
to
f8f4984
Compare
f8f4984
to
04184d6
Compare
15 tasks
Dzeranov
requested changes
Feb 26, 2025
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/common/guards/signature.auth.ts
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/config/web3-config.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/config/web3-config.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/cron-job/cron-job.module.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/email/module.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/kyc/kyc.controller.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/kyc/kyc.module.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/qualification/qualification.module.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/web3/web3.module.ts
Outdated
Show resolved
Hide resolved
67896f0
to
dbdf888
Compare
Dzeranov
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @portuu3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Part of #3084
Context behind the change
NetworkConfigService
because it violates common approach for config services: they should work only with env vars for simplicity, no custom logicWeb3ConfigService.operatorAddress
because we can derive this value from PK and avoid having another env var for addressfixtures
folder: place where we going to have all generators for test data and some hardcoded stuff when it's necessary to test exact values; later we will get rid oftest/constants
in favor of this foldercommon
&utils
& also fixed some tests thereConfigModule
because we have our config exported globallyproviders
listimports
to go as "libs", "outer modules/tools", "this module stuff"How has this been tested?
auth/web3/signup
endpoint to succeedRelease plan
Simply merge
Potential risks; What to monitor; Rollback plan
No