Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HUM-93 - refactor email verification pages #3009

Merged
merged 10 commits into from
Feb 28, 2025
Merged

HUM-93 - refactor email verification pages #3009

merged 10 commits into from
Feb 28, 2025

Conversation

adrian-oleskiewicz
Copy link
Contributor

@adrian-oleskiewicz adrian-oleskiewicz commented Jan 14, 2025 •
edited
Loading

Issue tracking

HUM-93

Context behind the change

  1. Refactor hook to align with SRP
  2. Code split into hooks, components, types
  3. Files renamed

How has this been tested?

registered new user and checked both pages displaying correctly

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025

@adrian-oleskiewicz is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@adrian-oleskiewicz adrian-oleskiewicz force-pushed the HUM-93-email-verification-page-refactor branch from 9159142 to 424e7de Compare January 20, 2025 13:54
@adrian-oleskiewicz adrian-oleskiewicz marked this pull request as ready for review January 22, 2025 07:44
@adrian-oleskiewicz
Copy link
Contributor Author

@dnechay ready to review

@dnechay dnechay self-requested a review January 22, 2025 14:37
dnechay
dnechay reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-organize things according to their business logic purpose, not by their nature

@dnechay
Copy link
Contributor

dnechay commented Jan 30, 2025

@mpblocky ^

@mpblocky mpblocky force-pushed the HUM-93-email-verification-page-refactor branch from 53a03d2 to 5e639c9 Compare February 3, 2025 14:21
@mpblocky
Copy link
Contributor

mpblocky commented Feb 4, 2025

@dnechay this one is ready

@dnechay dnechay self-requested a review February 10, 2025 09:19
dnechay
dnechay reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We can get rid of WorkerEmailVerificationProcessPage component: there is no need in isLoading state in useEmailVerificationToken hook, so this hook can be moved directly to EmailVerificationProcess component and that component becomes EmailVerificationProcessPage
  2. No need to have WorkerVerifyEmailPage because EmailVerificationFormContainer acts exactly like the "page"

@mpblocky mpblocky force-pushed the HUM-93-email-verification-page-refactor branch from 2fed918 to 9275c89 Compare February 24, 2025 10:41
@mpblocky
Copy link
Contributor

@dnechay bumping this comment as it might have been lost in the notifications 😅

@mpblocky mpblocky force-pushed the HUM-93-email-verification-page-refactor branch 2 times, most recently from e5677ba to 510d22e Compare February 27, 2025 08:38
@mpblocky
Copy link
Contributor

@dnechay resolved

@dnechay dnechay self-requested a review February 27, 2025 10:05
@mpblocky mpblocky force-pushed the HUM-93-email-verification-page-refactor branch from 510d22e to 3053825 Compare February 27, 2025 11:33
@vercel Vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 1:39pm

dnechay
dnechay reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now when you click on "Resend verification email" it sends BE request and then nothing happens. If you try to click again - it shows An error occurred, please try again. banner and not details, when under the hood it fails for captcha. This should be fixed (e.g. on staging we reload the page after it's successfully re-sent)

Also after sign-up it doesn't redirect to "email verification page" where it say "we've sent you email ......", it opens previous page with worker/operator sign-up (works fine on staging)

Please fix it.

In case you need different email addresses for tests purpose you can try:

  • using some disposable email services
  • if you have your email on Gmail - you can add +something to the main part, e.g. mpblocky+test-1@blockydevs.com and it will send email to your original account

@mpblocky
Copy link
Contributor

@dnechay I fixed the email resend and redirect. I also improved notifications using the new system and fixed missing p

@dnechay dnechay self-requested a review February 28, 2025 09:59
@dnechay dnechay merged commit 1ce0539 into humanprotocol:develop Feb 28, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Feb 28, 2025
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgacek-blockydevs mgacek-blockydevs mgacek-blockydevs left review comments

@mpblocky mpblocky mpblocky left review comments

@dnechay dnechay dnechay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrian-oleskiewicz @dnechay @mpblocky @mgacek-blockydevs