Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUM-91 - refactor profile module #3004

Merged

Conversation

adrian-oleskiewicz
Copy link
Contributor

@adrian-oleskiewicz adrian-oleskiewicz commented Jan 13, 2025

Issue tracking

HUM-91

Context behind the change

  1. Files structure refactor
  2. Split code (SRP): components, views, hooks, types

How has this been tested?

  • checked notifications in profile page
  • checked if it renders without errors
  • checked if its possible to use profile actions
  • checked if connecting wallet and registering address is possible in worker profile

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 13, 2025

@adrian-oleskiewicz is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@adrian-oleskiewicz adrian-oleskiewicz force-pushed the HUM-91-profile-components-refactor branch from 7a923f9 to 96af200 Compare January 22, 2025 14:28
@mpblocky mpblocky force-pushed the HUM-91-profile-components-refactor branch from ee55593 to 5b060fc Compare February 11, 2025 12:55
@adrian-oleskiewicz adrian-oleskiewicz marked this pull request as ready for review February 11, 2025 13:10
@mpblocky
Copy link
Contributor

@dnechay ready!

@dnechay dnechay self-requested a review February 11, 2025 15:11
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:12pm

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, let's push it to the finish line

@mpblocky mpblocky force-pushed the HUM-91-profile-components-refactor branch from c73141d to 1a8f01d Compare February 25, 2025 14:55
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Left some suggestions related to hooks naming/usage

@mpblocky
Copy link
Contributor

@dnechay fixed

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please resolve merge conflicts

@mpblocky mpblocky force-pushed the HUM-91-profile-components-refactor branch from 142ac1c to 26a9b01 Compare February 27, 2025 08:37
@mpblocky
Copy link
Contributor

@dnechay resolved

@dnechay dnechay self-requested a review February 27, 2025 10:05
@dnechay dnechay merged commit cdc1d89 into humanprotocol:develop Feb 27, 2025
3 of 8 checks passed
@dnechay dnechay mentioned this pull request Feb 27, 2025
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants