Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUM-89 - oracles table data refactor #2998

Merged

Conversation

adrian-oleskiewicz
Copy link
Contributor

@adrian-oleskiewicz adrian-oleskiewicz commented Jan 13, 2025

Issue tracking

HUM-89

Context behind the change

  1. Files structure refactor
  2. Split code (SRP): components, utils

How has this been tested?

  • checked display of oracles table both mobile and desktop
  • checked if selecting oracles works
  • checked if filtering works

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 13, 2025

@adrian-oleskiewicz is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@adrian-oleskiewicz adrian-oleskiewicz force-pushed the HUM-89-oracles-table-refactor branch from 3f3fcd3 to c0e1891 Compare January 22, 2025 13:17
@mpblocky mpblocky force-pushed the HUM-89-oracles-table-refactor branch from c0e1891 to 711d923 Compare February 11, 2025 13:45
@adrian-oleskiewicz adrian-oleskiewicz marked this pull request as ready for review February 25, 2025 08:47
@mpblocky mpblocky force-pushed the HUM-89-oracles-table-refactor branch from 96ded45 to cf64587 Compare February 25, 2025 09:37
@mpblocky
Copy link
Contributor

@dnechay ready!

@dnechay dnechay self-requested a review February 25, 2025 09:55
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 3:08pm

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Left some comments and please resolve merge conflict, I will carefully test it later

@mpblocky mpblocky force-pushed the HUM-89-oracles-table-refactor branch from 823b1a9 to b30fb34 Compare February 25, 2025 12:10
@mpblocky
Copy link
Contributor

@dnechay added chainId, all ready

@dnechay dnechay merged commit 76b128d into humanprotocol:develop Feb 26, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Feb 26, 2025
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants