Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Celo integration #1175

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add Celo integration #1175

merged 1 commit into from
Nov 10, 2023

Conversation

leetdev
Copy link
Contributor

@leetdev leetdev commented Oct 31, 2023

Description

Added Celo mainnet and Celo Alfajores testnet support to the relevant packages; deployed contracts, and added to the contracts list.

Summary of changes

See #123 for details. Create new subgraphs: celo, and celo-alfajores before merging.

Related issues

#123

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fortune-exchange-oracle-server 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 2:16pm

Copy link

vercel bot commented Oct 31, 2023

@leetdev is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@ansaqib
Copy link
Contributor

ansaqib commented Nov 1, 2023

@foufrix - Request review

@leetdev leetdev force-pushed the feat/add-celo branch 4 times, most recently from 73390e3 to 8d2dc56 Compare November 1, 2023 12:35
@foufrix
Copy link
Contributor

foufrix commented Nov 1, 2023

The code seems good to me.
Only thing is contracts are not verified: https://celoscan.io/address/0x19Ead835951493A763c96910255d5eeF147E914F#code

Possible to verify it using hardhat tutorial and tools

@foufrix
Copy link
Contributor

foufrix commented Nov 1, 2023

solve #123

@leetdev
Copy link
Contributor Author

leetdev commented Nov 1, 2023

The code seems good to me. Only thing is contracts are not verified: https://celoscan.io/address/0x19Ead835951493A763c96910255d5eeF147E914F#code

That one is the bridged token created by Wormhole. All the other contracts are verified using hardhat, see links in #123.

@foufrix
Copy link
Contributor

foufrix commented Nov 1, 2023

Effectively my bad there is 2 explorers, all good on celoscan.io

@leetdev
Copy link
Contributor Author

leetdev commented Nov 2, 2023

Rebased to the latest state of the develop branch.

I will reiterate that the following subraphs need to be created:

I also noticed that Escrow Dashboard now uses an API instead of querying the subgraphs directly, not sure if I have to do anything to make sure it supports the new networks.

@portuu3 - please review.

@portuu3
Copy link
Collaborator

portuu3 commented Nov 9, 2023

@leetdev since you were right about subgraph template, can you undo your last commit please? sorry for my mistake

@portuu3
Copy link
Collaborator

portuu3 commented Nov 9, 2023

I will create the subgraphs

@leetdev
Copy link
Contributor Author

leetdev commented Nov 9, 2023

@leetdev since you were right about subgraph template, can you undo your last commit please? sorry for my mistake

Done.

@portuu3
Copy link
Collaborator

portuu3 commented Nov 9, 2023

subgraphs created

@leetdev
Copy link
Contributor Author

leetdev commented Nov 9, 2023

subgraphs created

Ok. I think you can merge the PR now unless there is anything else you want me to do?

@portuu3 portuu3 merged commit 6ac31a0 into humanprotocol:develop Nov 10, 2023
@leetdev leetdev deleted the feat/add-celo branch November 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants