Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPCompatibility rules for PHP 7.2 #74

Closed
rmccue opened this issue Aug 7, 2018 · 3 comments · Fixed by #81
Closed

Add PHPCompatibility rules for PHP 7.2 #74

rmccue opened this issue Aug 7, 2018 · 3 comments · Fixed by #81
Assignees
@tfrommen
Labels
phpcs
Milestone
0.8

Comments

@rmccue
Copy link
Member

rmccue commented Aug 7, 2018

We should include the rules from PHPCompatibility for PHP 7.2 in the base set of rules, to ensure all greenfields code is compatible for when we roll it out to servers.
@rmccue
Copy link
Member Author

rmccue commented Aug 7, 2018

Specifically, the WP rules.

@rmccue
Copy link
Member Author

rmccue commented Aug 17, 2018

@tfrommen Do you have any specific code for this you can PR? 🙏

tfrommen added a commit that referenced this issue Aug 20, 2018
@tfrommen
Add PHPCompatibilityWP standard. #74
bbe0e3c 
Set it up to test for PHP version 7.0 or higher.
@tfrommen
Copy link
Contributor

Now I do, see #81. 🙂

@tfrommen tfrommen self-assigned this Aug 20, 2018
@tfrommen tfrommen mentioned this issue Dec 18, 2018
Merged
@mikeselander mikeselander added this to the 0.8 milestone Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfrommen tfrommen

Labels
phpcs
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Add PHPCompatibilityWP Standard. humanmade/coding-standards
3 participants
@rmccue @mikeselander @tfrommen