Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mime type search queries #98

Merged
merged 1 commit into from
Sep 10, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions inc/namespace.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ function load_elasticpress() {
add_filter( 'ep_term_formatted_args_query', __NAMESPACE__ . '\\enhance_term_search_query', 10, 2 );
add_filter( 'ep_user_formatted_args_query', __NAMESPACE__ . '\\enhance_user_search_query', 10, 2 );

// Fix the mime type search query.
add_filter( 'ep_formatted_args', __NAMESPACE__ . '\\fix_mime_type_query', 11, 2 );

// Back compat for ElasticPress v2 - change post index name to old version.
add_filter( 'ep_index_name', __NAMESPACE__ . '\\filter_index_name' );

Expand Down Expand Up @@ -268,6 +271,86 @@ function noop_wp_query_found_rows_on_failed_ep_request( string $sql, WP_Query $q
return '';
}

/**
* Modify the mime type query to support truncated forms.
*
* @param array $query The Elasticsearch query.
* @param array $args The WP_Query query vars.
* @return array
*/
function fix_mime_type_query( array $query, array $args ) : array {
if ( empty( $args['post_mime_type'] ) ) {
igmoweb marked this conversation as resolved.
Show resolved Hide resolved
return $query;
}

if ( ! isset( $query['post_filter'] ) ) {
return $query;
}

$filter = $query['post_filter']['bool']['must'] ?? [];

// Collect mime types in post filter.
$mime_types = [];

foreach ( $filter as $index => $sub_query ) {
// Extract list of mime types if present.
if ( ! empty( $sub_query['terms']['post_mime_type'] ) ) {
$mime_types = $sub_query['terms']['post_mime_type'];
}
// Extract base regex mime type if present.
if ( ! empty( $sub_query['regexp']['post_mime_type'] ) ) {
$mime_types = [ $sub_query['terms']['post_mime_type'] ];
}

if ( empty( $mime_types ) ) {
continue;
}

// Remove the existing mime type filter when we encounter it.
unset( $filter[ $index ] );
break;
}

if ( empty( $mime_types ) ) {
return $query;
}

// Collect fully qualified mime types here e.g. image/jpeg.
$terms = [];
// Collect prefix types here e.g. image, image/*.
$prefixes = [];

// Process mime types into prefixes and terms.
foreach ( $mime_types as $type ) {
// Remove trailing slashes and wildcards.
$type = rtrim( $type, './*' );
if ( strpos( $type, '/' ) !== false ) {
$terms[] = $type;
} else {
$prefixes[] = $type;
}
}

// Add the new prefix and terms queries together.
$mime_type_filter = [];
if ( ! empty( $terms ) ) {
$mime_type_filter[] = [ 'terms' => [ 'post_mime_type' => $terms ] ];
}
if ( ! empty( $prefixes ) ) {
foreach ( $prefixes as $prefix ) {
$mime_type_filter[] = [ 'prefix' => [ 'post_mime_type' => $prefix ] ];
}
}

// Add a compound query for our terms and prefixes.
if ( ! empty( $mime_type_filter ) ) {
$filter[] = [ 'bool' => [ 'should' => $mime_type_filter ] ];
$query['post_filter']['bool']['must'] = array_values( $filter );
}

return $query;
}

/**
* Add default initial options and settings on install.
*
Expand Down