fix: add NODE_ENV=test, fix autodetect and external msw/node

hugomrdias · Sep 29, 2023 · 62fe8e1 · 62fe8e1
1 parent b244658
commit 62fe8e1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/src/node/runner.js b/src/node/runner.js
@@ -64,6 +64,7 @@ export class NodeRunner {
     this.beforeTestsOutput = undefined
     this.env = merge(JSON.parse(JSON.stringify(process.env)), {
       PW_TEST: this.options,
+      NODE_ENV: 'test',
     })
     this.tests =
       testFiles ??

diff --git a/src/runner.js b/src/runner.js
@@ -56,6 +56,7 @@ export class Runner {
     this.watching = false
     this.env = merge(JSON.parse(JSON.stringify(process.env)), {
       PW_TEST: this.options,
+      NODE_ENV: 'test',
     })
     this.beforeTestsOutput = undefined
     this.tests =

diff --git a/src/utils/auto-detect.js b/src/utils/auto-detect.js
@@ -63,6 +63,7 @@ export function detectTestRunner(path, runners) {
 
     if (
       node.type === 'VariableDeclaration' &&
+      node.declarations[0].init &&
       node.declarations[0].init.callee &&
       node.declarations[0].init.callee.name === 'require' &&
       node.declarations[0].init.arguments &&

diff --git a/src/utils/index.js b/src/utils/index.js
@@ -437,7 +437,7 @@ await import('${require
     plugins: [nodePlugin, watchPlugin, wasmLoader()],
     outfile: outPath,
     inject: [path.join(__dirname, 'inject-process.js')],
-    external: ['node:async_hooks', 'node:fs'],
+    external: ['node:async_hooks', 'node:fs', 'msw/node'],
     define: {
       global: 'globalThis',
       PW_TEST_SOURCEMAP: runner.options.debug ? 'false' : 'true',