-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netlify-identity submodule #147
Conversation
Left the legacy hooks in place for backwards compatibility.
Ready for your review and merge @razonyang -- thank you! |
No need, workflow will handle it.
No need until we require particular version of upstream.
...y-identity/layouts/partials/hugopress/modules/decap-cms-netlify-identity/hooks/body-end.html
Show resolved
Hide resolved
Sorry for the delay response, just set up a demo on Netlify to see how it work. |
No, that code only gets executed in response to the netlify server, which returns to the homepage, and really needs to go to the admin page. Someone who is not editing using the CMS will never know that it’s there
…On Feb 8, 2024 at 7:18 PM -0800, Razon Yang ***@***.***>, wrote:
@razonyang commented on this pull request.
On modules/netlify-identity/layouts/partials/hugopress/modules/decap-cms-netlify-identity/hooks/body-end.html:
> That bit of code is required to redirect the response from the netlify identity server from / to /admin (or wherever you are going to base it). If no netlify response, it does nothing.
I'm still be confused by this, are you intend to force users to login into Decap CMS when they're visiting the homepage? For example, visit / -> not log in -> redirect to Decap CMS dashboard.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I took a look at the identity widget library docs, that code listend the |
For me the login button only appears on the admin page, but that code doesn’t know about admin so it returns to /, and without it, I never complete the login.
I don’t get any login button visible on root.
From decap docs:
When a user logs in with the Netlify Identity widget, an access token directs to the site homepage. In order to complete the login and get back to the CMS, redirect the user back to the /admin/ path. To do this, add the following script before the closing body tag of your site's main index page…
…On Feb 8, 2024 at 8:27 PM -0800, Razon Yang ***@***.***>, wrote:
> No, that code only gets executed in response to the netlify server, which returns to the homepage, and really needs to go to the admin page. Someone who is not editing using the CMS will never know that it’s there
I took a look at the identity widget library docs, that code listend the login event, so it seems that you've a login button on homepage, redirect to /admin after user login?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I get it, thanks for the references. |
Merged and drafted releases, thank you so much. |
Thank you, I learned a lot from you! |
Website needs to be updated to document this submodule, and the two parameters that may be overridden: